Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ghost-storage-base] add module types #36751

Merged
merged 8 commits into from Jul 11, 2019

Conversation

Projects
None yet
3 participants
@thde
Copy link
Contributor

commented Jul 9, 2019

Description

Based on the following:

Checklist

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to ghost-storage-base with its source on master.

Comparison details 📊
Batch compilation
Type count 9340
Assignability cache size 3018
Subtype cache size 4
Identity cache size 1
Language service measurements
Samples taken 54
Identifiers in tests 54
getCompletionsAtPosition
    Mean duration (ms) 352.6
    Median duration (ms) 349.8
    Mean CV 14.4%
    Worst duration (ms) 420.1
    Worst identifier image
getQuickInfoAtPosition
    Mean duration (ms) 367.8
    Median duration (ms) 365.5
    Mean CV 14.8%
    Worst duration (ms) 420.3
    Worst identifier MyCustomAdapter
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Jul 9, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@thde Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@thde The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Updated numbers for you here from 75c7b41:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to ghost-storage-base with its source on master.

Comparison details 📊
Batch compilation
Type count 9340
Assignability cache size 3018
Subtype cache size 4
Identity cache size 1
Language service measurements
Samples taken 54
Identifiers in tests 54
getCompletionsAtPosition
    Mean duration (ms) 351.2
    Median duration (ms) 348.1
    Mean CV 14.5%
    Worst duration (ms) 433.2
    Worst identifier delete
getQuickInfoAtPosition
    Mean duration (ms) 360.5
    Median duration (ms) 358.1
    Mean CV 16.3%
    Worst duration (ms) 412.9
    Worst identifier MyCustomAdapter
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure

@typescript-bot typescript-bot moved this from Needs Author Attention to Review in Pull Request Status Board Jul 9, 2019

thde added some commits Jul 9, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Updated numbers for you here from 538dd97:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to ghost-storage-base with its source on master.

Comparison details 📊
Batch compilation
Type count 9341
Assignability cache size 3018
Subtype cache size 4
Identity cache size 1
Language service measurements
Samples taken 54
Identifiers in tests 54
getCompletionsAtPosition
    Mean duration (ms) 359.0
    Median duration (ms) 356.0
    Mean CV 15.6%
    Worst duration (ms) 418.2
    Worst identifier NextFunction
getQuickInfoAtPosition
    Mean duration (ms) 348.7
    Median duration (ms) 349.6
    Mean CV 15.2%
    Worst duration (ms) 416.5
    Worst identifier Image
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Updated numbers for you here from 986bf7c:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to ghost-storage-base with its source on master.

Comparison details 📊
Batch compilation
Type count 9341
Assignability cache size 3018
Subtype cache size 4
Identity cache size 1
Language service measurements
Samples taken 54
Identifiers in tests 54
getCompletionsAtPosition
    Mean duration (ms) 311.3
    Median duration (ms) 307.6
    Mean CV 13.8%
    Worst duration (ms) 382.5
    Worst identifier fileName
getQuickInfoAtPosition
    Mean duration (ms) 338.3
    Median duration (ms) 336.1
    Mean CV 16.8%
    Worst duration (ms) 399.4
    Worst identifier NextFunction
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure

@armanio123 armanio123 merged commit bbccf6f into DefinitelyTyped:master Jul 11, 2019

4 checks passed

DefinitelyTyped.BenchmarkPR Build #8316 succeeded
Details
DefinitelyTyped.BenchmarkPR (Agent job 1) Agent job 1 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20190709.61 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Review to Done Jul 11, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@thde thde deleted the thde:ghost-storage-base branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.