Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-pdf: Update some types to use pdfjs-dist for better type safety #37424

Conversation

@nhardy
Copy link
Contributor

commented Aug 7, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

Minimum TypeScript version has been bumped to 3.0 to match the types for pdfjs-dist.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37424 diff
Batch compilation
Memory usage (MiB) 129.4 130.9 +1.2%
Type count 51917 51984 +0.1%
Assignability cache size 52444 52440 0.0%
Subtype cache size 16 18 +12.5%
Identity cache size 6 6 0.0%
Language service
Samples taken 38 39 +2.6%
Identifiers in tests 38 39 +2.6%
getCompletionsAtPosition
    Mean duration (ms) 641.1 642.7 +0.2%
    Median duration (ms) 643.0 637.3 -0.9%
    Mean CV 10.6% 12.3% +15.7%
    Worst duration (ms) 723.7 769.6 +6.3%
    Worst identifier pageNumber Document
getQuickInfoAtPosition
    Mean duration (ms) 617.1 591.1 -4.2%
    Median duration (ms) 618.1 579.4 -6.2%
    Mean CV 14.7% 12.6% -13.9%
    Worst duration (ms) 709.7 711.5 +0.3%
    Worst identifier pageNumber Page

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@nhardy Thank you for submitting this PR!

🔔 @CodeDaraW - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Aug 7, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sandersn sandersn merged commit d3d1295 into DefinitelyTyped:master Aug 7, 2019

3 checks passed

DefinitelyTyped.BenchmarkPR Build #11141 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20190807.5 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Check and Merge to Done Aug 7, 2019

schmod added a commit to schmod/DefinitelyTyped that referenced this pull request Aug 8, 2019

Merge branch 'master' of github.com:DefinitelyTyped/DefinitelyTyped i…
…nto lodash-flattendeep-chain

* 'master' of github.com:DefinitelyTyped/DefinitelyTyped: (22 commits)
  [c3] Update all c3 types to meet latest documentation and source code (DefinitelyTyped#37139)
  Fix typo in mongoose-deep-populate (DefinitelyTyped#37336)
  Create conductor-animate types (DefinitelyTyped#37431)
  [lscache] Update version to v.1.3.0  (DefinitelyTyped#37255)
  Add types for bayes-classifier (DefinitelyTyped#37337)
  Add type definitions for `react-inspector` (DefinitelyTyped#37421)
  react-gateway: Allow functional components in GatewayDest 'component' prop. (DefinitelyTyped#37445)
  Fixed intro.js module export (DefinitelyTyped#37416)
  react-pdf: Update some types to use pdfjs-dist for better type safety (DefinitelyTyped#37424)
  [snoowrap] not needed as of 1.19.0 (DefinitelyTyped#37394)
  [newrelic] Allow promise transaction handlers. (DefinitelyTyped#37417)
  [react-transition-group] Unify to standard module syntax (DefinitelyTyped#37405)
  Added verify & sign options valid for 8.5.1 (DefinitelyTyped#37419)
  [office-js] [office-js-preview] (Outlook) Link to error object (DefinitelyTyped#37407)
  [office-js] (Outlook) Remove preview API (DefinitelyTyped#37420)
  [office-js] [office-js-preview] (Outlook) Add note about Outlook value (DefinitelyTyped#37441)
  fix(@types/mongodb): make _id optional for collection.insertX functions (DefinitelyTyped#37402)
  jasmine: Add definitionAdded static falsy, truthy, empty, notEmpty (DefinitelyTyped#37428)
  [node] Bugfix tty read write stream constructor (DefinitelyTyped#37174)
  [@types/carbon-components-react] [NEW] New types package for carbon-components-react. (DefinitelyTyped#37442)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.