Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yargs-parser] Add config options `strip-dashed` and `strip-aliased` #38108

Merged
merged 4 commits into from Sep 5, 2019

Conversation

@sqren
Copy link
Contributor

commented Sep 3, 2019

yargs-parser v.13.1.0 (2019-05-05) added the config options strip-dashed and strip-aliased
https://github.com/yargs/yargs-parser/blob/master/CHANGELOG.md#1310-2019-05-05

The full list of configurations can be found: https://github.com/yargs/yargs-parser/blob/d3d9027f9c9235be8e7a650d0e33d4d55287e0e2/index.js#L28-L29

Please fill in this template.

[yargs-parser] Add config options `strip-dashed` and `strip-aliased`
yargs-parser v.13.1.0 (2019-05-05) added the config options `strip-dashed` and `strip-aliased`
https://github.com/yargs/yargs-parser/blob/master/CHANGELOG.md#1310-2019-05-05
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38108 diff
Batch compilation
Memory usage (MiB) 37.3 37.5 +0.5%
Type count 2246 2250 +0.2%
Assignability cache size 140 140 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 63 63 0.0%
Identifiers in tests 63 63 0.0%
getCompletionsAtPosition
    Mean duration (ms) 80.6 79.6 -1.2%
    Median duration (ms) 80.8 78.3 -3.1%
    Mean CV 27.8% 27.0% -3.1%
    Worst duration (ms) 109.1 107.6 -1.4%
    Worst identifier coerce arg
getQuickInfoAtPosition
    Mean duration (ms) 78.7 76.6 -2.7%
    Median duration (ms) 76.1 77.4 +1.8%
    Mean CV 25.8% 25.1% -2.6%
    Worst duration (ms) 111.4 99.6 -10.6%
    Worst identifier boolean parse

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@sqren Thank you for submitting this PR!

🔔 @milesj - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@milesj
milesj approved these changes Sep 4, 2019

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Sep 4, 2019

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Updated numbers for you here from d7b049e:

Comparison details 📊
master #38108 diff
Batch compilation
Memory usage (MiB) 37.3 37.3 0.0%
Type count 2246 2250 +0.2%
Assignability cache size 140 140 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 63 63 0.0%
Identifiers in tests 63 63 0.0%
getCompletionsAtPosition
    Mean duration (ms) 87.1 88.7 +1.9%
    Median duration (ms) 82.4 81.8 -0.7%
    Mean CV 26.3% 25.3% -4.1%
    Worst duration (ms) 111.3 123.4 +10.9%
    Worst identifier arg coerce
getQuickInfoAtPosition
    Mean duration (ms) 86.7 85.4 -1.5%
    Median duration (ms) 82.6 80.0 -3.2%
    Mean CV 26.0% 22.9% -12.1%
    Worst duration (ms) 127.2 115.7 -9.1%
    Worst identifier parse count

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

sqren added 2 commits Sep 4, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Updated numbers for you here from 8ca2d23:

Comparison details 📊
master #38108 diff
Batch compilation
Memory usage (MiB) 37.3 33.8 -9.3%
Type count 2246 2250 +0.2%
Assignability cache size 140 140 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 63 63 0.0%
Identifiers in tests 63 63 0.0%
getCompletionsAtPosition
    Mean duration (ms) 87.0 92.1 +5.8%
    Median duration (ms) 82.7 82.4 -0.3%
    Mean CV 25.1% 28.7% +14.3%
    Worst duration (ms) 118.9 128.3 +7.9%
    Worst identifier arg configuration
getQuickInfoAtPosition
    Mean duration (ms) 84.9 86.9 +2.3%
    Median duration (ms) 82.3 80.7 -1.9%
    Mean CV 24.0% 24.0% +0.1%
    Worst duration (ms) 109.0 118.3 +8.5%
    Worst identifier configuration configuration

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

@amcasey amcasey merged commit de1035d into DefinitelyTyped:master Sep 5, 2019

3 checks passed

DefinitelyTyped.BenchmarkPR Build #14228 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20190904.59 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Pull Request Status Board automation moved this from Check and Merge to Done Sep 5, 2019

@sqren sqren deleted the sqren:patch-1 branch Sep 5, 2019

life777 added a commit to life777/DefinitelyTyped that referenced this pull request Sep 11, 2019
[yargs-parser] Add config options `strip-dashed` and `strip-aliased` (D…
…efinitelyTyped#38108)

* [yargs-parser] Add config options `strip-dashed` and `strip-aliased`

yargs-parser v.13.1.0 (2019-05-05) added the config options `strip-dashed` and `strip-aliased`
https://github.com/yargs/yargs-parser/blob/master/CHANGELOG.md#1310-2019-05-05

* Update date in header

* Drop patch version to fix CI

* Drop patch version to fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.