Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing labelFontSize prop definition to react-native-material-dropdown #38393

Merged
merged 1 commit into from Sep 24, 2019

Conversation

PC98
Copy link
Contributor

@PC98 PC98 commented Sep 15, 2019

No description provided.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38393 diff
Batch compilation
Memory usage (MiB) 103.7 104.3 +0.6%
Type count 48816 48817 0.0%
Assignability cache size 19347 19347 0.0%
Subtype cache size 41 41 0.0%
Identity cache size 3 3 0.0%
Language service
Samples taken 77 77 0.0%
Identifiers in tests 77 77 0.0%
getCompletionsAtPosition
    Mean duration (ms) 390.2 387.8 -0.6%
    Median duration (ms) 381.9 382.9 +0.3%
    Mean CV 13.3% 13.6% +1.9%
    Worst duration (ms) 483.7 484.5 +0.2%
    Worst identifier onLayout React
getQuickInfoAtPosition
    Mean duration (ms) 380.9 381.2 +0.1%
    Median duration (ms) 379.6 373.6 -1.6%
    Mean CV 13.1% 14.2% +7.9%
    Worst duration (ms) 468.3 473.2 +1.1%
    Worst identifier index renderBase

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 15, 2019

@PC98 Thank you for submitting this PR!

🔔 @jaydeep987 @mchappell - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Sep 20, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Sep 20, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 20, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Copy link
Contributor

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition 👍

@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Sep 24, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Sep 24, 2019
@mrcrane
Copy link
Contributor

mrcrane commented Sep 24, 2019

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@mrcrane mrcrane merged commit e46cfc9 into DefinitelyTyped:master Sep 24, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Sep 24, 2019
@PC98 PC98 deleted the patch-1 branch September 24, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants