Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for the @loadable/webpack-plugin package #38397

Merged

Conversation

@skovy
Copy link
Contributor

skovy commented Sep 16, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Sep 16, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to loadable__webpack-plugin with its source on master.

Comparison details 📊
Batch compilation
Type count 10528
Assignability cache size 3265
Subtype cache size 0
Identity cache size 1
Language service measurements
Samples taken 17
Identifiers in tests 17
getCompletionsAtPosition
    Mean duration (ms) 380.9
    Median duration (ms) 381.5
    Mean CV 11.1%
    Worst duration (ms) 419.1
    Worst identifier config
getQuickInfoAtPosition
    Mean duration (ms) 392.1
    Median duration (ms) 383.3
    Mean CV 13.3%
    Worst duration (ms) 470.2
    Worst identifier plugins
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Sep 16, 2019

Updated numbers for you here from 16bd940:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to loadable__webpack-plugin with its source on master.

Comparison details 📊
Batch compilation
Type count 10528
Assignability cache size 3265
Subtype cache size 0
Identity cache size 1
Language service measurements
Samples taken 17
Identifiers in tests 17
getCompletionsAtPosition
    Mean duration (ms) 388.1
    Median duration (ms) 395.3
    Mean CV 12.4%
    Worst duration (ms) 438.2
    Worst identifier LoadablePlugin
getQuickInfoAtPosition
    Mean duration (ms) 401.9
    Median duration (ms) 410.5
    Mean CV 13.5%
    Worst duration (ms) 470.5
    Worst identifier writeToDisk
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Sep 16, 2019

@skovy Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Sep 21, 2019

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@uniqueiniquity uniqueiniquity merged commit b552194 into DefinitelyTyped:master Sep 24, 2019
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #15310 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20190916.5 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Review to Done Sep 24, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Sep 24, 2019

@skovy skovy deleted the skovy:skovy/add-loadable-webpack-plugin branch Sep 24, 2019
1999 added a commit to 1999/DefinitelyTyped that referenced this pull request Sep 24, 2019
* upstream/master: (65 commits)
  react-bootstrap: add restoreFocus prop to Modal (DefinitelyTyped#38424)
  add PaymentRequestButtonElementProps (DefinitelyTyped#38432)
  [@types/prop-types] update `props` type for `Validator` (DefinitelyTyped#38442)
  Remove of unnecessary import in "react-redux" (DefinitelyTyped#38563)
  @pollyjs/core - Improve on previous types and update to match v2.6.2 (DefinitelyTyped#38554)
  [victory] update definitions for VictoryTheme, add className to VictoryLabel (DefinitelyTyped#38141)
  Adding a new package: jwk-to-pem (DefinitelyTyped#38511)
  Add pizzip types (DefinitelyTyped#38527)
  sqlite3-promise type definitions (DefinitelyTyped#38504)
  Add types for rox-browser (DefinitelyTyped#38452)
  express-rate-limit: remove wrong `new` (DefinitelyTyped#38399)
  Add types for package-info (DefinitelyTyped#38235)
  [pino-http] Add err to ServerResponse (DefinitelyTyped#38426)
  fixed typo in bittorrent-protocol types (DefinitelyTyped#38469)
  Ensures that prettier has the same settings as editorconfig (DefinitelyTyped#38569)
  [@types/google-apps-script] Fix Spreadsheet.Protection, Cache (DefinitelyTyped#38323)
  Add types for the @loadable/webpack-plugin package (DefinitelyTyped#38397)
  fix: update `RequestPromise` extension for 2018 `Promise` (DefinitelyTyped#38471)
  [express-useragent] Add v1 types (DefinitelyTyped#38408)
  Update index.d.ts (DefinitelyTyped#38454)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.