[@storybook__*] Delete Storybook types

[MichaelDeBoey]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.

Select one of these and delete the others:

If removing a declaration:

• Delete the package's directory.
• Add it to notNeededPackages.json.

---

All packages were migrated to TS (which is tracked in storybookjs/storybook#5030) and provide their own typings.

I deleted the typings for the following packages:

• @storybook/addon-actions
• @storybook/addon-backgrounds
• @storybook/addon-centered
• @storybook/addon-jest
• @storybook/addon-knobs
• @storybook/addon-links
• @storybook/addon-options
• @storybook/addon-viewport
• @storybook/addons
• @storybook/channels
• @storybook/html
• @storybook/preact
  Set to 5.2.1 since 5.2 typings were already published here even tho that package version wasn't released yet
• @storybook/react
• @storybook/react-native
• @storybook/vue

[typescript-bot]

@MichaelDeBoey Thank you for submitting this PR!

🔔 @joscha @jicjjang @HyunSeob @adhrinae @kiyopikko @halfmatthalfcat @martynaskadisa @amacleay @MLoughry @alanhchoi @azmenak @jessepinho @simonhn @gaetanmaisse @adam187 @Vinnl @bmatcuk @ChristianMurphy @9renpoto @ddayguerrero @wapgear @alechill @iRoachie @ceyhuno @pntgupta @jurgisrudaks @yoyoys - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

@MichaelDeBoey The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[joscha]

What happens to consumers of pre-5.2.0 versions if there are any problems with the types? Adding the packages to notNeededPackages.json looks good to me, but I think we should keep the typings around for a little longer?

[joscha]

Requesting changes until the question is addressed, slo it doesn't accidentally get merged.

[joscha]

.

[MichaelDeBoey]

@joscha I just followed the workflow as explained in the PR template and the docs.

Other deleted types (see #34111 & #37358) just deleted the corresponding folders too.

[joscha]

@joscha I just followed the workflow as explained in the PR template and the docs .

ah, so the output of this PR is from npm run not-needed -- typingsPackageName asOfVersion sourceRepoURL [libraryName].? I guess that's expected then? Feels a bit strange that we wouldn't be able to update typings for older versions any more, but 🤷‍♂

[MichaelDeBoey]

@joscha Yes it does 🙂

[MichaelDeBoey]

Or maybe somebody from the @storybookjs team can help me out? 🤔

CC @gaetanmaisse @kroeder @ndelangen @shilman @emilio-martinez @lonyele @benoitdion @dandean @sairus2k

[MichaelDeBoey]

I've reverted the removal of the @storybook/react, so this can already be merged.

I'll create a new PR for it when this one's merged. 🙂

[ndelangen]

What can I do to help here?

[MichaelDeBoey]

@ndelangen I'll tag you in the new PR after this one's merged.
But that one will have the same issue as we had here, so maybe you can have a look at the error that we had? 🤔

https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/591252348

[typescript-bot]

🔔 @joscha - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

[MichaelDeBoey]

Ping @joscha @ExE-Boss for approval

[joscha]

Sorry, I still don't really have an answer as to what happens with the pre-5.2.0 versions after we merge this, so I don't really know whether this should be approved or not.

[MichaelDeBoey]

@joscha This is just the normal flow of deleting typings from the repo.

Since their's a new version published to npm when we update typings, I guess this won't happen anymore and the old @types/storybook__* will still be existing on the npm registry.

[joscha]

Yeah, sorry, let me clarify. I understand we don't need to worry about the new version, I also understand removing them makes sense. I am just wondering what happens if someone uses 4.x for a while longer (not out of the question as the upgrade is not straightforward) and we encounter a typing error - what do we do then?

…

On Fri, 4 Oct 2019, 22:19 Michaël De Boey, ***@***.***> wrote: @joscha <https://github.com/joscha> This is just the normal flow of deleting typings from the repo. Since their's a new version published to npm when we update typings, I guess this won't happen anymore and the old @types/storybook__* will still be existing on the npm registry. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38447?email_source=notifications&email_token=AABN5BWMWWARCCNT7PKDJPLQM4YFFA5CNFSM4IXWC36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEALOZBQ#issuecomment-538373254>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABN5BXKNC4BJOTGVL6VSJLQM4YFFANCNFSM4IXWC36A> .

[MichaelDeBoey]

@joscha I think this is a general thing that needs to be discussed elsewhere, no? 🤔

Maybe temporarily add them back, fix the typing error, publish the fix and delete them again? 🤔
This seems to me like we shouldn't hold back this PR.

[ndelangen]

@joscha We don't actively maintain or support 4.x anymore.

I'm personally not too concerned with this "what happens if" scenario, users have options:

My recommendation would be to use a fork, a local type definition or https://www.npmjs.com/package/patch-package

And hopefully the option of upgrading is available..

My main concern is that storybook 5.x users should remove the packages as soon as possible, because they are incompatible with the 5.x releases.

[joscha]

I do understand, we already migrated to v5 so I am not being cautious because of myself, I sincerely think the v4 -> v5 update we did was not the easiest so I am a bit worried about us just dropping these types and making it our user's problem. But I can see you are all pushing for this and if noone else thinks it is a problem, maybe I shouldn't either...

…

On Tue, 8 Oct 2019, 05:02 Norbert de Langen, ***@***.***> wrote: @joscha <https://github.com/joscha> We don't actively maintain or support 4.x anymore. I'm personally not too concerned with this "what happens if" scenario, users have options: My recommendation would be to use a fork, a local type definition or https://www.npmjs.com/package/patch-package And hopefully the option of upgrading is available.. My main concern is that storybook 5.x users should remove the packages as soon as possible, because they are incompatible with the 5.x releases. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38447?email_source=notifications&email_token=AABN5BSKI7DPUNNPUCCFIWTQNN2SLA5CNFSM4IXWC36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARIKLI#issuecomment-539133229>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABN5BUMHI7JPXBEDK3MG4TQNN2SLANCNFSM4IXWC36A> .

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[Mussabaheen]

GREAT