Skip to content

add new functions for recaptcha v3 - #38948

Merged
armanio123 merged 4 commits into
DefinitelyTyped:masterfrom
RohrerF:patch-1
Oct 9, 2019
Merged

armanio123 merged 4 commits into
DefinitelyTyped:masterfrom
RohrerF:patch-1

Conversation

@RohrerF

@RohrerF RohrerF commented Oct 7, 2019 •

Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

probably resolves #33540

@typescript-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38948 diff
Batch compilation
Memory usage (MiB) 78.1 77.4 -0.9%
Type count 8911 8913 0.0%
Assignability cache size 32515 32515 0.0%
Subtype cache size 0 0
Identity cache size 3 3 0.0%
Language service
Samples taken 76 76 0.0%
Identifiers in tests 76 76 0.0%
getCompletionsAtPosition
    Mean duration (ms) 376.2 371.3 -1.3%
    Median duration (ms) 369.9 366.6 -0.9%
    Mean CV 16.0% 15.1% -5.8%
    Worst duration (ms) 511.3 468.7 -8.3%
    Worst identifier grecaptcha id1
getQuickInfoAtPosition
    Mean duration (ms) 358.8 355.9 -0.8%
    Median duration (ms) 356.8 357.9 +0.3%
    Mean CV 14.9% 14.3% -4.0%
    Worst duration (ms) 463.6 442.3 -4.6%
    Worst identifier id1 id1

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@RohrerF
RohrerF marked this pull request as ready for review October 7, 2019 15:18
@typescript-bot

typescript-bot commented Oct 7, 2019 •

Copy link
Copy Markdown
Contributor

@RohrerF Thank you for submitting this PR!

🔔 @DethAriel @rafaeltavares - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Comment thread types/grecaptcha/index.d.ts
@typescript-bot

Copy link
Copy Markdown
Contributor

Updated numbers for you here from 280b362:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to grecaptcha with its source on master.

Comparison details 📊
Batch compilation
Type count 8931
Assignability cache size 32517
Subtype cache size 1
Identity cache size 3
Language service measurements
Samples taken 83
Identifiers in tests 83
getCompletionsAtPosition
    Mean duration (ms) 363.4
    Median duration (ms) 358.7
    Mean CV 14.6%
    Worst duration (ms) 433.6
    Worst identifier ReCaptchaV2
getQuickInfoAtPosition
    Mean duration (ms) 344.6
    Median duration (ms) 340.9
    Mean CV 14.2%
    Worst duration (ms) 397.4
    Worst identifier size2
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1059-azure

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Oct 8, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123
armanio123 merged commit fb5531f into DefinitelyTyped:master Oct 9, 2019
@typescript-bot

Copy link
Copy Markdown
Contributor

I just published @types/grecaptcha@3.0.0 to npm.

alexanderson1993 pushed a commit to alexanderson1993/DefinitelyTyped that referenced this pull request Oct 11, 2019
* add new functions for recaptcha v3

* formatting

* test file updated

* Update index.d.ts
chivesrs pushed a commit to chivesrs/DefinitelyTyped that referenced this pull request Nov 19, 2019
* add new functions for recaptcha v3

* formatting

* test file updated

* Update index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@types/grecaptcha]

4 participants