Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated types for @types/twit #38985

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

@Darkade
Copy link
Contributor

Darkade commented Oct 8, 2019

Added parameters to interface Param to allow calling more Twitter stream API endpoints

Please fill in this template.

  • [ X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ X ] Test the change in your own code. (Compile and run.)
  • [ X ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ X ] Follow the advice from the readme.
  • [ X ] Avoid common mistakes.
  • [ X ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ X ] Provide a URL to documentation or source code which provides context for the suggested changes: https://developer.twitter.com/en/docs/accounts-and-users/follow-search-get-users/api-reference/get-friendships-show
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
Added parameters to `interface Param` to allow calling more Twitter stream API endpoints
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Oct 8, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #38985 diff
Batch compilation
Memory usage (MiB) 62.4 64.9 +4.0%
Type count 8350 8350 0.0%
Assignability cache size 914 914 0.0%
Subtype cache size 1 1 0.0%
Identity cache size 0 0
Language service
Samples taken 30 30 0.0%
Identifiers in tests 30 30 0.0%
getCompletionsAtPosition
    Mean duration (ms) 411.9 333.3 -19.1%
    Median duration (ms) 411.0 333.2 -18.9%
    Mean CV 16.0% 14.6% -8.7%
    Worst duration (ms) 472.8 401.6 -15.1%
    Worst identifier app_only_auth app_only_auth
getQuickInfoAtPosition
    Mean duration (ms) 432.1 339.2 -21.5%
    Median duration (ms) 433.5 330.8 -23.7%
    Mean CV 12.9% 15.8% +22.6%
    Worst duration (ms) 500.0 427.6 -14.5%
    Worst identifier res post
System information
Node version v10.16.3 v10.16.3
CPU count 2 2
CPU speed 2.294 GHz 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1059-azure 4.15.0-1059-azure

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Oct 8, 2019

@Darkade Thank you for submitting this PR!

🔔 @Volox @sapphiredev @abraham @siwalikm @PLhery @JustGoscha - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@abraham
abraham approved these changes Oct 9, 2019
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Oct 9, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Oct 9, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@armanio123 armanio123 merged commit bb80320 into DefinitelyTyped:master Oct 9, 2019
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #17981 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20191008.65 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Check and Merge to Done Oct 9, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Oct 9, 2019

I just published @types/twit@2.2.23 to npm.

ddimitrioglo added a commit to ddimitrioglo/DefinitelyTyped that referenced this pull request Oct 10, 2019
Added parameters to `interface Param` to allow calling more Twitter stream API endpoints
alexanderson1993 pushed a commit to alexanderson1993/DefinitelyTyped that referenced this pull request Oct 11, 2019
Added parameters to `interface Param` to allow calling more Twitter stream API endpoints
chivesrs added a commit to chivesrs/DefinitelyTyped that referenced this pull request Nov 19, 2019
Added parameters to `interface Param` to allow calling more Twitter stream API endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.