Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
helmet: Add featurePolicy #39673
feture-policy provides TS typings with it, but it doesn't export the
Please fill in this template.
Select one of these and delete the others:
If changing an existing definition:
feture-policy provides TS typings with it, but it doesn't export the interface for the options parameter. We could have used conditional typings and infered the type of the parameter, but that would have restricted the minimum TS version to 2.8, so instead I created the interface definition here. Resolves #37627
@tomi Thank you for submitting this PR!
If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.
Let’s review the numbers, shall we?
|Memory usage (MiB)||69.3||65.6||-5.4%|
|Assignability cache size||1057||1062||0%|
|Identifiers in tests||323||342||+6%|
|Mean duration (ms)||380.1||382.9||+0.7%|
|Worst duration (ms)||462.6||497.8||+7.6%|
|Mean duration (ms)||396.1||397.2||+0.3%|
|Worst duration (ms)||487.8||521.5||+6.9%|
It looks like nothing changed too much. I won’t post performance data again unless it gets worse.