Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prompts] Update types to account for new override function #40136

merged 2 commits into from Nov 6, 2019


Copy link

Whoaa512 commented Nov 4, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: terkelg/prompts#144
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

This comment has been minimized.

Copy link

typescript-bot commented Nov 4, 2019

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #40136 diff
Batch compilation
Memory usage (MiB) 38.1 30.8 -19.2%
Type count 2315 2316 0%
Assignability cache size 180 180 0%
Language service
Samples taken 44 44 0%
Identifiers in tests 44 44 0%
    Mean duration (ms) 104.5 102.1 -2.4%
    Mean CV 27.8% 26.6%
    Worst duration (ms) 145.2 138.0 -4.9%
    Worst identifier type type
    Mean duration (ms) 102.8 103.1 +0.3%
    Mean CV 23.9% 25.9% +8.5%
    Worst duration (ms) 135.6 130.4 -3.8%
    Worst identifier choices choices

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.


This comment has been minimized.

Copy link

typescript-bot commented Nov 4, 2019

@Whoaa512 Thank you for submitting this PR!

🔔 @Berkays @danielpa9708 @kamontat @theweirdone - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Berkays approved these changes Nov 6, 2019
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Nov 6, 2019

This comment has been minimized.

Copy link

typescript-bot commented Nov 6, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@sandersn sandersn merged commit bdb0d39 into DefinitelyTyped:master Nov 6, 2019
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #22832 succeeded
DefinitelyTyped.DefinitelyTyped Build #20191105.83 succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Pull Request Status Board automation moved this from Check and Merge to Done Nov 6, 2019
@Whoaa512 Whoaa512 deleted the Whoaa512:prompts branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.