Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types for react-collapse@5 #40362

Merged

Conversation

@selbekk
Copy link
Contributor

selbekk commented Nov 13, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/nkbt/react-collapse
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Nov 13, 2019

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to react-collapse with its source on master.

Comparison details 📊
Batch compilation
Type count 15222
Assignability cache size 18813
Language service measurements
Samples taken 55
Identifiers in tests 55
getCompletionsAtPosition
    Mean duration (ms) 321.0
    Mean CV 13.6%
    Worst duration (ms) 417.3
    Worst identifier UnmountClosed
getQuickInfoAtPosition
    Mean duration (ms) 297.7
    Mean CV 13.8%
    Worst duration (ms) 385.2
    Worst identifier onWork
System information
Node version v12.13.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1061-azure
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Nov 13, 2019

@selbekk Thank you for submitting this PR!

🔔 @Kimahriman - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Nov 13, 2019

@selbekk The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@selbekk selbekk force-pushed the selbekk:react-collapse-types branch from eb659d8 to a9c69ea Nov 13, 2019
@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board Nov 13, 2019
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Nov 15, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Nov 15, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@PranavSenthilnathan PranavSenthilnathan merged commit 8f3259b into DefinitelyTyped:master Nov 15, 2019
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #23850 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20191113.31 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Check and Merge to Done Nov 15, 2019
@PranavSenthilnathan

This comment has been minimized.

Copy link
Contributor

PranavSenthilnathan commented Nov 15, 2019

Congratulations on your first DefinitelyTyped contribution! Thank you for being a part of the community!

@selbekk

This comment has been minimized.

Copy link
Contributor Author

selbekk commented Nov 16, 2019

Thanks!

@selbekk selbekk deleted the selbekk:react-collapse-types branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.