From f3355eb45eae26959bfc01606c1f5e5c409290d7 Mon Sep 17 00:00:00 2001
From: Connor Clark <cjamcl@gmail.com>
Date: Fri, 15 Nov 2019 18:01:56 -0800
Subject: [PATCH] update puppeteer to use the its generated cdp protocol types

---
 types/puppeteer/index.d.ts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts
index d71efcd442b268..d4f63d043af926 100644
--- a/types/puppeteer/index.d.ts
+++ b/types/puppeteer/index.d.ts
@@ -15,6 +15,9 @@
 
 import { EventEmitter } from "events";
 import { ChildProcess } from "child_process";
+// @ts-ignore: suppress error if using an older version of puppeteer, which don't
+// publish types for the protocol.
+import Protocol from 'puppeteer/lib/protocol';
 
 import * as errors from "./Errors";
 import * as devices from "./DeviceDescriptors";
@@ -2155,10 +2158,13 @@ export interface CDPSession extends EventEmitter {
    */
   detach(): Promise<void>;
 
+  on<T extends keyof Protocol.Events>(event: T, listener: (arg: Protocol.Events[T]) => void): this;
+
   /**
    * @param method Protocol method name
+   * @param parameters Protocol parameters
    */
-  send(method: string, params?: object): Promise<object>;
+  send<T extends keyof Protocol.CommandParameters>(method: T, parameters?: Protocol.CommandParameters[T]): Promise<Protocol.CommandReturnValues[T]>;
 }
 
 export interface Coverage {