Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onBeforeCapture to React-Beautiful-DnD #41131

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@pimterry
Copy link
Contributor

pimterry commented Dec 18, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: atlassian/react-beautiful-dnd#1605 (flow types shown here: https://github.com/atlassian/react-beautiful-dnd/blob/master/docs/guides/types.md#responders)
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header (I suspect there's other changes too, so I'll leave this for now)
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Dec 18, 2019

@pimterry Thank you for submitting this PR!

🔔 @varHarrie @bradleyayers @paustint @marknelissen @enricoboccadifuoco @lonyele @lukyth - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Dec 18, 2019

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #41131 diff
Batch compilation
Memory usage (MiB) 114.0 112.8 -1.0%
Type count 23162 23169 0%
Assignability cache size 53583 53587 0%
Language service
Samples taken 199 205 +3%
Identifiers in tests 199 205 +3%
getCompletionsAtPosition
    Mean duration (ms) 605.0 590.4 -2.4%
    Mean CV 9.3% 9.2%
    Worst duration (ms) 801.4 747.8 -6.7%
    Worst identifier placeholder placeholder
getQuickInfoAtPosition
    Mean duration (ms) 603.2 589.8 -2.2%
    Mean CV 9.7% 10.1% +3.6%
    Worst duration (ms) 803.8 790.5 -1.7%
    Worst identifier content provided

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Copy link
Contributor

bradleyayers left a comment

lgtm

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Dec 18, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Dec 18, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@andrewbranch andrewbranch merged commit d7fbc2e into DefinitelyTyped:master Dec 23, 2019
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #27518 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20191218.69 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Check and Merge to Done Dec 23, 2019
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Dec 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.