Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LJHarb to LJHarb's packages #42138

Merged
merged 1 commit into from Feb 7, 2020
Merged

Conversation

@ljharb
Copy link
Contributor

ljharb commented Feb 6, 2020

This adds me as an owner on my own packages.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Follow the advice from the readme.
  • Avoid common mistakes.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

per #41988 (comment)

@ljharb ljharb requested a review from jessetrinity Feb 6, 2020
@ljharb ljharb force-pushed the ljharb:add-myself branch from 2782bbe to 516dda4 Feb 6, 2020
@ljharb ljharb requested a review from Bartvds as a code owner Feb 6, 2020
@ljharb ljharb force-pushed the ljharb:add-myself branch from 516dda4 to cada522 Feb 6, 2020
@ljharb

This comment has been minimized.

Copy link
Contributor Author

ljharb commented Feb 6, 2020

k, i think that's all of the packages i maintain, but i didn't exhaustively look through the list.

It'd be kind of nice if DT automatically looked up the npm owners and pinged them :-)

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 6, 2020

@ljharb Thank you for submitting this PR!

🔔 @kylejlin @hallettj @ExE-Boss @MarianPalkus @NoHomey @jwbay @huhuanming @MartynasZilinskas @thovden @Hotell @screendriver @mateuszsokola @BraidenCutforth @erickzhao @jtomaszewski @tkrotoff @nali @adamzerella @Richienb @wbhob @danwbyrne @demurgos @Akuukis @VitorLuizC @jurca @kisaraofpern @slavik57 @BendingBender @RWander @leonyu @tehbelinda @zyml @artursvonda @CarlosBonetti @dpsmith3 @hperrin @Bartvds @sodatea @DennisSchwartz @mikehenrty @rostrowski @adamvoss @dex4er - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 6, 2020

@ljharb The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 6, 2020

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

array.prototype.flat/v1

Comparison details for array.prototype.flat/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 33.5 33.5 0.0%
Type count 3934 3934 0%
Assignability cache size 879 879 0%
Language service
Samples taken 76 76 0%
Identifiers in tests 76 76 0%
getCompletionsAtPosition
    Mean duration (ms) 81.1 85.3 +5.1%
    Mean CV 19.9% 22.0%
    Worst duration (ms) 128.3 126.9 -1.1%
    Worst identifier shim flat
getQuickInfoAtPosition
    Mean duration (ms) 89.7 94.0 +4.8%
    Mean CV 19.4% 22.2% +14.1%
    Worst duration (ms) 118.1 139.0 +17.7%
    Worst identifier flatImpl flat

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

array.prototype.flatmap/v1

Comparison details for array.prototype.flatmap/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 33.6 33.2 -1.2%
Type count 2253 2253 0%
Assignability cache size 163 163 0%
Language service
Samples taken 84 84 0%
Identifiers in tests 84 84 0%
getCompletionsAtPosition
    Mean duration (ms) 84.9 85.2 +0.4%
    Mean CV 23.8% 25.5%
    Worst duration (ms) 122.2 117.1 -4.2%
    Worst identifier split word
getQuickInfoAtPosition
    Mean duration (ms) 82.8 83.9 +1.4%
    Mean CV 21.4% 23.5% +9.5%
    Worst duration (ms) 112.1 117.7 +5.0%
    Worst identifier split word

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

define-properties/v1

Comparison details for define-properties/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 34.2 34.0 -0.4%
Type count 2280 2280 0%
Assignability cache size 162 162 0%
Language service
Samples taken 47 47 0%
Identifiers in tests 47 47 0%
getCompletionsAtPosition
    Mean duration (ms) 87.3 91.0 +4.2%
    Mean CV 25.0% 26.3%
    Worst duration (ms) 127.6 117.5 -7.9%
    Worst identifier define bar
getQuickInfoAtPosition
    Mean duration (ms) 85.6 89.5 +4.6%
    Mean CV 24.0% 25.3% +5.2%
    Worst duration (ms) 120.8 118.2 -2.1%
    Worst identifier define bar

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

enzyme-adapter-react-15.4/v1

Comparison details for enzyme-adapter-react-15.4/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 116.9 106.4 -9.0%
Type count 21742 21742 0%
Assignability cache size 21487 21487 0%
Language service
Samples taken 5 5 0%
Identifiers in tests 5 5 0%
getCompletionsAtPosition
    Mean duration (ms) 604.8 595.4 -1.6%
    Mean CV 10.9% 10.2%
    Worst duration (ms) 645.6 614.0 -4.9%
    Worst identifier adapter Adapter
getQuickInfoAtPosition
    Mean duration (ms) 613.5 602.7 -1.8%
    Mean CV 12.2% 11.2% -8.2%
    Worst duration (ms) 682.7 633.3 -7.2%
    Worst identifier adapter adapter

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

enzyme-adapter-react-15/v1

Comparison details for enzyme-adapter-react-15/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 140.7 141.0 +0.2%
Type count 29195 29195 0%
Assignability cache size 55857 55857 0%
Language service
Samples taken 5 5 0%
Identifiers in tests 5 5 0%
getCompletionsAtPosition
    Mean duration (ms) 896.2 877.3 -2.1%
    Mean CV 10.6% 11.4%
    Worst duration (ms) 990.7 952.8 -3.8%
    Worst identifier Adapter Adapter
getQuickInfoAtPosition
    Mean duration (ms) 858.0 898.8 +4.7%
    Mean CV 8.3% 13.5% +61.6%
    Worst duration (ms) 915.2 952.2 +4.1%
    Worst identifier adapter configure

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

enzyme-adapter-react-16/v1

Comparison details for enzyme-adapter-react-16/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 141.1 151.2 +7.2%
Type count 29195 29195 0%
Assignability cache size 55857 55857 0%
Language service
Samples taken 5 5 0%
Identifiers in tests 5 5 0%
getCompletionsAtPosition
    Mean duration (ms) 908.6 878.7 -3.3%
    Mean CV 14.9% 11.7%
    Worst duration (ms) 960.5 964.0 +0.4%
    Worst identifier Adapter Adapter
getQuickInfoAtPosition
    Mean duration (ms) 873.6 901.0 +3.1%
    Mean CV 13.6% 15.2% +11.9%
    Worst duration (ms) 898.8 960.6 +6.9%
    Worst identifier configure Adapter

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

enzyme/v3

Comparison details for enzyme/v3 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 149.8 136.4 -9.0%
Type count 34504 34504 0%
Assignability cache size 57703 57703 0%
Language service
Samples taken 1630 1630 0%
Identifiers in tests 1630 1630 0%
getCompletionsAtPosition
    Mean duration (ms) 750.2 698.7 -6.9%
    Mean CV 9.8% 10.1%
    Worst duration (ms) 1098.4 972.2 -11.5%
    Worst identifier reactWrapper AnotherComponent
getQuickInfoAtPosition
    Mean duration (ms) 743.6 692.4 -6.9%
    Mean CV 9.9% 10.0% +0.8%
    Worst duration (ms) 1049.9 943.4 -10.1%
    Worst identifier closest find

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

function-bind/v1

Comparison details for function-bind/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 38.9 37.8 -2.6%
Type count 3544 3544 0%
Assignability cache size 214 214 0%
Language service
Samples taken 114 114 0%
Identifiers in tests 114 114 0%
getCompletionsAtPosition
    Mean duration (ms) 79.4 79.9 +0.6%
    Mean CV 20.4% 20.4%
    Worst duration (ms) 116.7 124.7 +6.8%
    Worst identifier string number
getQuickInfoAtPosition
    Mean duration (ms) 76.1 77.3 +1.5%
    Mean CV 20.6% 20.9% +1.7%
    Worst duration (ms) 111.0 113.7 +2.5%
    Worst identifier apply apply

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

internal-slot/v1

Comparison details for internal-slot/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 33.3 33.5 +0.7%
Type count 1347 1347 0%
Assignability cache size 119 119 0%
Language service
Samples taken 65 65 0%
Identifiers in tests 65 65 0%
getCompletionsAtPosition
    Mean duration (ms) 45.8 46.7 +2.1%
    Mean CV 29.3% 33.9%
    Worst duration (ms) 74.6 66.7 -10.6%
    Worst identifier Infinity Infinity
getQuickInfoAtPosition
    Mean duration (ms) 45.8 44.8 -2.0%
    Mean CV 33.3% 30.7% -7.8%
    Worst duration (ms) 63.2 59.7 -5.5%
    Worst identifier forEach assert

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

is-date-object/v1

Comparison details for is-date-object/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 32.4 32.6 +0.4%
Type count 2150 2150 0%
Assignability cache size 110 110 0%
Language service
Samples taken 17 17 0%
Identifiers in tests 17 17 0%
getCompletionsAtPosition
    Mean duration (ms) 61.1 61.3 +0.3%
    Mean CV 18.5% 17.5%
    Worst duration (ms) 75.1 72.7 -3.2%
    Worst identifier isDate Date
getQuickInfoAtPosition
    Mean duration (ms) 59.0 60.7 +2.9%
    Mean CV 17.8% 21.1% +18.1%
    Worst duration (ms) 74.1 69.7 -5.9%
    Worst identifier RegExp isDate

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

is-generator-function/v1

Comparison details for is-generator-function/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 36.0 32.7 -9.2%
Type count 2142 2142 0%
Assignability cache size 110 110 0%
Language service
Samples taken 2 2 0%
Identifiers in tests 2 2 0%
getCompletionsAtPosition
    Mean duration (ms) 90.9 92.5 +1.7%
    Mean CV 29.1% 25.6%
    Worst duration (ms) 94.1 92.8 -1.4%
    Worst identifier isGeneratorFunction isGeneratorFunction
getQuickInfoAtPosition
    Mean duration (ms) 75.3 74.8 -0.7%
    Mean CV 19.0% 19.6% +3.4%
    Worst duration (ms) 78.2 80.4 +2.8%
    Worst identifier isGeneratorFunction isGeneratorFunction

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

is-object/v1

Comparison details for is-object/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 32.4 32.4 +0.1%
Type count 2140 2140 0%
Assignability cache size 110 110 0%
Language service
Samples taken 10 10 0%
Identifiers in tests 10 10 0%
getCompletionsAtPosition
    Mean duration (ms) 59.2 62.6 +5.8%
    Mean CV 21.6% 24.9%
    Worst duration (ms) 66.1 70.4 +6.4%
    Worst identifier Array Object
getQuickInfoAtPosition
    Mean duration (ms) 60.8 59.7 -1.8%
    Mean CV 24.3% 22.8% -6.0%
    Worst duration (ms) 66.5 67.3 +1.2%
    Worst identifier isObject isObject

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

json-file-plus/v3

Comparison details for json-file-plus/v3 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 61.7 60.0 -2.7%
Type count 9281 9281 0%
Assignability cache size 2996 2996 0%
Language service
Samples taken 27 27 0%
Identifiers in tests 27 27 0%
getCompletionsAtPosition
    Mean duration (ms) 272.2 266.8 -2.0%
    Mean CV 15.6% 15.1%
    Worst duration (ms) 324.7 353.3 +8.8%
    Worst identifier file saveSync
getQuickInfoAtPosition
    Mean duration (ms) 272.4 268.4 -1.5%
    Mean CV 15.7% 16.1% +2.3%
    Worst duration (ms) 335.5 330.3 -1.6%
    Worst identifier sync example

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

object-inspect/v1

Comparison details for object-inspect/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 32.8 32.8 0.0%
Type count 2157 2157 0%
Assignability cache size 114 114 0%
Language service
Samples taken 15 15 0%
Identifiers in tests 15 15 0%
getCompletionsAtPosition
    Mean duration (ms) 60.2 61.4 +2.1%
    Mean CV 19.9% 20.8%
    Worst duration (ms) 70.8 71.6 +1.1%
    Worst identifier foo foo
getQuickInfoAtPosition
    Mean duration (ms) 61.7 61.5 -0.3%
    Mean CV 21.9% 19.5% -10.6%
    Worst duration (ms) 78.2 79.0 +1.1%
    Worst identifier quoteStyle quoteStyle

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

object-keys/v1

Comparison details for object-keys/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 32.5 32.3 -0.5%
Type count 2146 2146 0%
Assignability cache size 111 111 0%
Language service
Samples taken 12 12 0%
Identifiers in tests 12 12 0%
getCompletionsAtPosition
    Mean duration (ms) 65.2 65.4 +0.3%
    Mean CV 23.2% 23.1%
    Worst duration (ms) 72.7 87.6 +20.5%
    Worst identifier testArguments keys
getQuickInfoAtPosition
    Mean duration (ms) 62.3 62.0 -0.6%
    Mean CV 17.2% 21.5% +25.1%
    Worst duration (ms) 85.0 76.0 -10.6%
    Worst identifier keys keys

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

object.getownpropertydescriptors/v2

Comparison details for object.getownpropertydescriptors/v2 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 31.1 31.0 -0.2%
Type count 2175 2175 0%
Assignability cache size 120 120 0%
Language service
Samples taken 16 16 0%
Identifiers in tests 16 16 0%
getCompletionsAtPosition
    Mean duration (ms) 63.3 62.6 -1.1%
    Mean CV 23.1% 22.6%
    Worst duration (ms) 79.6 78.6 -1.3%
    Worst identifier descriptors implementation
getQuickInfoAtPosition
    Mean duration (ms) 61.6 62.2 +0.9%
    Mean CV 21.8% 21.2% -3.0%
    Worst duration (ms) 79.3 83.6 +5.5%
    Worst identifier descriptors descriptors

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

promise.allsettled/v1

Comparison details for promise.allsettled/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 34.8 34.7 -0.2%
Type count 2495 2495 0%
Assignability cache size 576 576 0%
Language service
Samples taken 51 51 0%
Identifiers in tests 51 51 0%
getCompletionsAtPosition
    Mean duration (ms) 70.7 73.0 +3.2%
    Mean CV 23.9% 24.9%
    Worst duration (ms) 102.0 103.5 +1.5%
    Worst identifier Promise T
getQuickInfoAtPosition
    Mean duration (ms) 70.8 73.3 +3.5%
    Mean CV 22.3% 25.5% +14.1%
    Worst duration (ms) 89.1 102.4 +14.9%
    Worst identifier r3 allSettled

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

promise.prototype.finally/v2

Comparison details for promise.prototype.finally/v2 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 34.6 34.7 +0.1%
Type count 2420 2420 0%
Assignability cache size 142 142 0%
Language service
Samples taken 64 64 0%
Identifiers in tests 64 64 0%
getCompletionsAtPosition
    Mean duration (ms) 64.1 64.8 +1.0%
    Mean CV 23.7% 24.5%
    Worst duration (ms) 99.8 91.5 -8.3%
    Worst identifier resolved resolved
getQuickInfoAtPosition
    Mean duration (ms) 64.6 65.6 +1.5%
    Mean CV 22.9% 23.8% +4.3%
    Worst duration (ms) 87.5 104.6 +19.5%
    Worst identifier then then

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

qs/v6

Comparison details for qs/v6 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 29.0 32.3 +11.5%
Type count 2571 2571 0%
Assignability cache size 197 197 0%
Language service
Samples taken 474 474 0%
Identifiers in tests 474 474 0%
getCompletionsAtPosition
    Mean duration (ms) 61.5 60.7 -1.4%
    Mean CV 16.2% 15.1%
    Worst duration (ms) 94.4 87.6 -7.2%
    Worst identifier stringify e
getQuickInfoAtPosition
    Mean duration (ms) 61.1 60.3 -1.4%
    Mean CV 16.2% 15.1% -6.7%
    Worst duration (ms) 98.1 80.9 -17.5%
    Worst identifier stringify prefix

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

tape/v4

Comparison details for tape/v4 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 65.5 67.1 +2.4%
Type count 8278 8278 0%
Assignability cache size 857 857 0%
Language service
Samples taken 542 542 0%
Identifiers in tests 542 542 0%
getCompletionsAtPosition
    Mean duration (ms) 245.8 248.3 +1.0%
    Mean CV 9.7% 9.6%
    Worst duration (ms) 394.9 314.4 -20.4%
    Worst identifier CustomException msg
getQuickInfoAtPosition
    Mean duration (ms) 243.9 246.5 +1.1%
    Mean CV 10.0% 9.6% -4.8%
    Worst duration (ms) 323.8 321.2 -0.8%
    Worst identifier msg isNotDeeply

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

util.promisify/v1

Comparison details for util.promisify/v1 📊
master #42138 diff
Batch compilation
Memory usage (MiB) 62.6 59.4 -5.0%
Type count 9271 9271 0%
Assignability cache size 2955 2955 0%
Language service
Samples taken 23 23 0%
Identifiers in tests 23 23 0%
getCompletionsAtPosition
    Mean duration (ms) 270.1 267.0 -1.1%
    Mean CV 15.8% 12.5%
    Worst duration (ms) 359.0 321.6 -10.4%
    Worst identifier promisify promisifyShim
getQuickInfoAtPosition
    Mean duration (ms) 276.5 265.4 -4.0%
    Mean CV 14.4% 11.1% -23.1%
    Worst duration (ms) 339.9 307.0 -9.7%
    Worst identifier util promisify

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

Copy link
Contributor

ExE-Boss left a comment

The package.json#dependencies object shouldn’t be present if empty, see #40009 and #42147.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ExE-Boss ExE-Boss mentioned this pull request Feb 6, 2020
6 of 6 tasks complete
@ljharb ljharb force-pushed the ljharb:add-myself branch from cada522 to 1b7496f Feb 6, 2020
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Feb 6, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 6, 2020

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@ljharb ljharb force-pushed the ljharb:add-myself branch from 1b7496f to fcfb365 Feb 7, 2020
@wbhob
wbhob approved these changes Feb 7, 2020
@jessetrinity jessetrinity merged commit 6fdd80d into DefinitelyTyped:master Feb 7, 2020
3 checks passed
3 checks passed
DefinitelyTyped.BenchmarkPR Build #33941 succeeded
Details
DefinitelyTyped.DefinitelyTyped Build #20200207.3 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Check and Merge to Done Feb 7, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

I just published @types/enzyme@3.10.5 to npm.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

I just published @types/is-object@1.0.1 to npm.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Feb 7, 2020

@ljharb ljharb deleted the ljharb:add-myself branch Feb 7, 2020
@ljharb

This comment has been minimized.

Copy link
Contributor Author

ljharb commented Feb 7, 2020

Not sure these needed publishing for just a comment change ;-)

@jessetrinity

This comment has been minimized.

Copy link
Contributor

jessetrinity commented Feb 7, 2020

Comment only PRs are probably rare enough that none of us have noticed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.