Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slick-carousel] Enable noImplicitThis #42950

Open
wants to merge 1 commit into
base: master
from

Conversation

@jablko
Copy link
Contributor

jablko commented Mar 6, 2020

No description provided.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 6, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 6, 2020

@jablko Thank you for submitting this PR!

🔔 @Kocal - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@Kocal

This comment has been minimized.

Copy link
Contributor

Kocal commented Mar 6, 2020

Hello, why this change?

Copy link
Contributor

Kocal left a comment

I won't approve unless you explain your change and you will the PR template.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Mar 7, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 7, 2020

@jablko One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@jablko

This comment has been minimized.

Copy link
Contributor Author

jablko commented Mar 11, 2020

This makes the automated tests a bit stricter. Before the change, if someone used the types in a project where noImplicitThis: true, the DefinitelyTyped automation wouldn't catch breaking changes to the types.

@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 13, 2020

@jablko I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@jablko jablko force-pushed the jablko:noImplicitThis/slick-carousel branch from b0ca712 to c1d8cab Mar 13, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 13, 2020

🔔 @Kocal - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@ExE-Boss

This comment has been minimized.

Copy link
Contributor

ExE-Boss commented Mar 13, 2020

The PR description should use the PR template.

Also, you should probably copy your comment into the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Request Status Board
  
Needs Author Attention
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.