[NodeGit] Remote.create is async #43310

SferaDev · 2020-03-22T10:44:05Z

Reference: https://www.nodegit.org/api/remote/#create

typescript-bot · 2020-03-22T11:22:31Z

@SferaDev Thank you for submitting this PR!

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

orta · 2020-03-22T11:22:41Z

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

orta · 2020-03-22T11:22:42Z

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

orta · 2020-03-22T12:22:38Z

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

orta · 2020-03-22T12:22:38Z

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

orta · 2020-03-22T12:22:41Z

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

typescript-bot · 2020-03-23T00:22:41Z

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

typescript-bot · 2020-03-23T15:44:19Z

I just published @types/nodegit@0.26.2 to npm.

[NodeGit] Remote.create is async

a5763fa

Reference: https://www.nodegit.org/api/remote/#create

orta added the Where is Travis? label Mar 22, 2020

orta added this to Other in New Pull Request Status Board Mar 22, 2020

orta removed the Where is Travis? label Mar 22, 2020

orta moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Mar 22, 2020

typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 22, 2020

typescript-bot added the Awaiting reviewer feedback label Mar 22, 2020

orta added The Travis CI build failed Owner Approved A listed owner of this package signed off on the pull request. Critical package Author is Owner The author of this PR is a listed owner of the package. labels Mar 22, 2020

typescript-bot removed Owner Approved A listed owner of this package signed off on the pull request. Author is Owner The author of this PR is a listed owner of the package. The Travis CI build failed labels Mar 22, 2020

orta added The Travis CI build failed and removed Critical package labels Mar 22, 2020

typescript-bot removed the The Travis CI build failed label Mar 22, 2020

tniessen approved these changes Mar 22, 2020

View reviewed changes

typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Mar 23, 2020

typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Mar 23, 2020

typescript-bot added the Merge:Express label Mar 23, 2020

orta approved these changes Mar 23, 2020

View reviewed changes

orta merged commit 155dd34 into DefinitelyTyped:master Mar 23, 2020

Pull Request Status Board automation moved this from Check and Merge to Done Mar 23, 2020

typescript-bot removed this from Done in Pull Request Status Board Mar 23, 2020

orta removed this from Waiting for Code Reviews in New Pull Request Status Board May 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NodeGit] Remote.create is async #43310

[NodeGit] Remote.create is async #43310

SferaDev commented Mar 22, 2020 •

edited

typescript-bot commented Mar 22, 2020 •

edited

orta commented Mar 22, 2020

orta commented Mar 22, 2020

orta commented Mar 22, 2020

orta commented Mar 22, 2020

orta commented Mar 22, 2020

typescript-bot commented Mar 23, 2020

typescript-bot commented Mar 23, 2020

[NodeGit] Remote.create is async #43310

[NodeGit] Remote.create is async #43310

Conversation

SferaDev commented Mar 22, 2020 • edited

typescript-bot commented Mar 22, 2020 • edited

orta commented Mar 22, 2020

Code Reviews

Status

orta commented Mar 22, 2020

Code Reviews

Status

orta commented Mar 22, 2020

Code Reviews

Status

orta commented Mar 22, 2020

Code Reviews

Status

orta commented Mar 22, 2020

Code Reviews

Status

typescript-bot commented Mar 23, 2020

typescript-bot commented Mar 23, 2020

SferaDev commented Mar 22, 2020 •

edited

typescript-bot commented Mar 22, 2020 •

edited