Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeGit] Remote.create is async #43310

Merged
merged 1 commit into from Mar 23, 2020
Merged

[NodeGit] Remote.create is async #43310

merged 1 commit into from Mar 23, 2020

Conversation

@SferaDev
Copy link
Contributor

SferaDev commented Mar 22, 2020

@orta orta removed the Where is Travis? label Mar 22, 2020
@orta orta moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Mar 22, 2020
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 22, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 22, 2020

@SferaDev Thank you for submitting this PR!

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@orta

This comment has been minimized.

Copy link
Collaborator

orta commented Mar 22, 2020

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

  • No merge conflicts
  • Continuous integration tests have passed
  • Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}
1 similar comment
@orta

This comment has been minimized.

Copy link
Collaborator

orta commented Mar 22, 2020

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

  • No merge conflicts
  • Continuous integration tests have passed
  • Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}
@orta

This comment has been minimized.

Copy link
Collaborator

orta commented Mar 22, 2020

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

  • No merge conflicts
  • Continuous integration tests have passed
  • Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}
1 similar comment
@orta

This comment has been minimized.

Copy link
Collaborator

orta commented Mar 22, 2020

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

  • No merge conflicts
  • Continuous integration tests have passed
  • Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}
@orta

This comment has been minimized.

Copy link
Collaborator

orta commented Mar 22, 2020

@SferaDev Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 - keep an eye on this comment as I'll be updating it with information as things progress.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

🔔 @dolanmiu @tniessen @pvigier @IGI-111 @DaGaMs - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Status

  • No merge conflicts
  • Continuous integration tests have passed
  • Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "pr_number": 43310,
  "author": "SferaDev",
  "owners": [
    "dolanmiu",
    "tniessen",
    "pvigier",
    "IGI-111",
    "DaGaMs"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a5763fa",
  "headCommitOid": "a5763fae8428b845c21004c130e200f6854a72b9",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-03-22T10:43:57.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43310/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": true,
  "popularityLevel": "Well-liked by everyone",
  "anyPackageIsNew": false,
  "packages": [
    "nodegit"
  ],
  "files": [
    {
      "filePath": "types/nodegit/remote.d.ts",
      "kind": "definition",
      "package": "nodegit"
    }
  ],
  "otherApprovalCount": 0,
  "ownerApprovalCount": 0,
  "maintainerApprovalCount": 0,
  "hasDismissedReview": false,
  "travisResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Mar 23, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 23, 2020

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@orta
orta approved these changes Mar 23, 2020
@orta orta merged commit 155dd34 into DefinitelyTyped:master Mar 23, 2020
2 checks passed
2 checks passed
DefinitelyTyped.DefinitelyTyped Build #20200322.4 succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Pull Request Status Board automation moved this from Check and Merge to Done Mar 23, 2020
@typescript-bot

This comment has been minimized.

Copy link
Contributor

typescript-bot commented Mar 23, 2020

I just published @types/nodegit@0.26.2 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
New Pull Request Status Board
Waiting for Code Reviews
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.