Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prettier] Update to v2 #43576

Merged
merged 9 commits into from Apr 2, 2020
Merged

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Apr 2, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://prettier.io/blog/2020/03/21/2.0.0.html>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Apr 2, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 2, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 2, 2020

@sosukesuzuki Thank you for submitting this PR!

🔔 @ikatyang @ifiokjr @ffflorian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 2, 2020

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Apr 2, 2020
@uniqueiniquity uniqueiniquity merged commit 5210039 into DefinitelyTyped:master Apr 2, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Apr 2, 2020
@typescript-bot
Copy link
Contributor

I just published @types/prettier@2.0.0 to npm.

@sosukesuzuki sosukesuzuki deleted the prettier2 branch April 3, 2020 01:10
sandersn added a commit that referenced this pull request Apr 23, 2020
This fixes up #43576. Normally we would not even add types for a
version of a package that ships its own types, because module resolution
will never cause the compiler use the old types from `@types`. So it
doesn't matter that

```sh
$ npm install react-bootstrap @types/react-bootstrap
```

gives you `react-bootstrap@1.0` and `@types/react-bootstrap@0.32`

So I think the best thing to do is to delete the 1.0 files. There's no
reason to update `@types/react-bootstrap@1.0` again.
elibarzilay pushed a commit that referenced this pull request Apr 26, 2020
* Better fake deprecate of @types/react-bootstrap@1

This fixes up #43576. Normally we would not even add types for a
version of a package that ships its own types, because module resolution
will never cause the compiler use the old types from `@types`. So it
doesn't matter that

```sh
$ npm install react-bootstrap @types/react-bootstrap
```

gives you `react-bootstrap@1.0` and `@types/react-bootstrap@0.32`

So I think the best thing to do is to delete the 1.0 files. There's no
reason to update `@types/react-bootstrap@1.0` again.

* Revert "Better fake deprecate of @types/react-bootstrap@1"

This reverts commit 2ad1da4.

* Add tslint.json and empty export instead
jjballano-qatium pushed a commit to jjballano-qatium/DefinitelyTyped that referenced this pull request Jun 16, 2020
* Better fake deprecate of @types/react-bootstrap@1

This fixes up DefinitelyTyped#43576. Normally we would not even add types for a
version of a package that ships its own types, because module resolution
will never cause the compiler use the old types from `@types`. So it
doesn't matter that

```sh
$ npm install react-bootstrap @types/react-bootstrap
```

gives you `react-bootstrap@1.0` and `@types/react-bootstrap@0.32`

So I think the best thing to do is to delete the 1.0 files. There's no
reason to update `@types/react-bootstrap@1.0` again.

* Revert "Better fake deprecate of @types/react-bootstrap@1"

This reverts commit 2ad1da4.

* Add tslint.json and empty export instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants