Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] Add tangentialPressure, twist to PointerEvent #43589

Merged
merged 2 commits into from Apr 9, 2020
Merged

[react] Add tangentialPressure, twist to PointerEvent #43589

merged 2 commits into from Apr 9, 2020

Conversation

disjukr
Copy link
Contributor

@disjukr disjukr commented Apr 2, 2020

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Apr 2, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 2, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 2, 2020 •
edited

@disjukr Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Needs Author Attention in Pull Request Status Board Apr 2, 2020
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. The Travis CI build failed and removed Awaiting reviewer feedback labels Apr 2, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 2, 2020 •
edited

@disjukr The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@disjukr
Copy link
Contributor Author

disjukr commented Apr 3, 2020

um... it is timeout error. i just want rerun the travis ci but i dont know how.
need i change commit hash and force push it only to rerun the ci?

@disjukr
Copy link
Contributor Author

disjukr commented Apr 5, 2020

#20308

@typescript-bot
Copy link
Contributor

@disjukr I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@disjukr disjukr closed this Apr 8, 2020
Pull Request Status Board automation moved this from Needs Author Attention to Done Apr 8, 2020
@disjukr disjukr reopened this Apr 8, 2020
@typescript-bot typescript-bot moved this from Done to Check and Merge in Pull Request Status Board Apr 8, 2020
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board Apr 8, 2020
@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. and removed Merge:Express labels Apr 8, 2020
@typescript-bot
Copy link
Contributor

@disjukr Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Apr 9, 2020
@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Apr 9, 2020
@RyanCavanaugh RyanCavanaugh merged commit 82f5b79 into DefinitelyTyped:master Apr 9, 2020
Pull Request Status Board automation moved this from Check and Merge to Done Apr 9, 2020
@typescript-bot
Copy link
Contributor

I just published @types/react@16.9.34 to npm.

@disjukr disjukr deleted the react branch April 11, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdaber ferdaber ferdaber approved these changes

@Jessidhia Jessidhia Awaiting requested review from Jessidhia Jessidhia is a code owner

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly is a code owner

Assignees
No one assigned
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@disjukr @typescript-bot @ferdaber @RyanCavanaugh