Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALBResult in aws-lambda #45936

Merged
merged 1 commit into from Jul 10, 2020

Conversation

donaldpipowitch
Copy link
Contributor

@donaldpipowitch donaldpipowitch commented Jul 7, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

As far as I can tell statusDescription and isBase64Encoded are optional. E.g. statusDescription is also not a part of this official example: https://github.com/aws/elastic-load-balancing-tools/blob/master/application-load-balancer-serverless-app/whatismyip/whatismyip.py#L14

But I'm not super familiar with the API. There are several old blog post which says that those fields are required, but my tests can't verify this. Same results for me if I drop those fields? Maybe ALB changed it's behavior?

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jul 7, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 7, 2020

@donaldpipowitch Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45936,
  "author": "donaldpipowitch",
  "owners": [
    "darbio",
    "skarum",
    "StefH",
    "tobyhede",
    "buggy",
    "y13i",
    "wwwy3y3",
    "OrthoDex",
    "MichaelMarner",
    "daniel-cottone",
    "kostya-misura",
    "coderbyheart",
    "palmithor",
    "daniloraisi",
    "simonbuchan",
    "Haydabase",
    "repl-chris",
    "aneilbaboo",
    "jeznag",
    "louislarry",
    "dpapukchiev",
    "ohookins",
    "trevor-leach",
    "jagregory",
    "dalen",
    "loikg",
    "skyzenr",
    "redlickigrzegorz",
    "juancarbonel",
    "pwmcintyre",
    "alex-bolenok-centralreach",
    "marianzange",
    "apepper",
    "apalumbo",
    "SachinShekhar",
    "ivanmartos",
    "zach-anthony"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "96d0a76",
  "headCommitOid": "96d0a76490511813bda14fdb0d241b93647dfb46",
  "mergeIsRequested": false,
  "stalenessInDays": 2,
  "lastPushDate": "2020-07-07T19:17:19.000Z",
  "lastCommentDate": "2020-07-07T19:17:19.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45936/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "aws-lambda"
  ],
  "files": [
    {
      "path": "types/aws-lambda/trigger/alb.d.ts",
      "kind": "definition",
      "package": "aws-lambda"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-07T23:49:54.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot typescript-bot removed the Where is GH Actions? GH Actions didn't give a response to this PR label Jul 7, 2020
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Jul 7, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 7, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45936 diff
Batch compilation
Memory usage (MiB) 74.8 74.8 +0.1%
Type count 10976 10976 0%
Assignability cache size 2327 2327 0%
Language service
Samples taken 2026 2066 +2%
Identifiers in tests 3188 3188 0%
getCompletionsAtPosition
    Mean duration (ms) 355.9 354.7 -0.3%
    Mean CV 7.9% 7.7%
    Worst duration (ms) 475.4 468.6 -1.4%
    Worst identifier CodeBuildCloudWatchStateEvent logs
getQuickInfoAtPosition
    Mean duration (ms) 358.1 356.7 -0.4%
    Mean CV 8.2% 8.1% -1.5%
    Worst duration (ms) 459.2 496.5 +8.1%
    Worst identifier snsEventCodeBuildStateHandler codeBuildStateEventDetail

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jul 7, 2020
Copy link
Contributor

@simonbuchan simonbuchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is pretty poor in general about lambda triggers. This seems fine to me since you've tested it working without them!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 7, 2020
@weswigham weswigham merged commit 070f243 into DefinitelyTyped:master Jul 10, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jul 10, 2020
@typescript-bot
Copy link
Contributor

I just published @types/aws-lambda@8.10.59 to npm.

ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants