[d3-dsv] Update types to v1.2

[Methuselah96]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/d3/d3-dsv/releases/tag/v1.2.0
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

Related: #38939

[typescript-bot]

@Methuselah96 Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• d3-dsv on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48330,
  "author": "Methuselah96",
  "owners": [
    "tomwanzek",
    "gustavderdrache",
    "borisyankov",
    "denisname",
    "Methuselah96"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "5ef066a",
  "headCommitOid": "5ef066a613f327d49deb28032924a18554fdd3b0",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-09-30T00:42:35.000Z",
  "lastCommentDate": "2020-09-30T21:00:19.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48330/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "d3-dsv"
  ],
  "files": [
    {
      "path": "types/d3-dsv/d3-dsv-tests.ts",
      "kind": "test",
      "package": "d3-dsv"
    },
    {
      "path": "types/d3-dsv/index.d.ts",
      "kind": "definition",
      "package": "d3-dsv"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-09-30T20:59:30.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 4,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @tomwanzek @gustavderdrache @borisyankov @denisname — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

bull/v*

Comparison details for bull/* 📊

	master	#48330	diff
Batch compilation
Memory usage (MiB)	75.2	73.7	-1.9%
Type count	10080	10080	0%
Assignability cache size	1808	1808	0%
Language service
Samples taken	359	359	0%
Identifiers in tests	359	359	0%
getCompletionsAtPosition
Mean duration (ms)	382.5	384.6	+0.5%
Mean CV	8.5%	8.8%
Worst duration (ms)	469.9	496.5	+5.7%
Worst identifier	videoQueue	on
getQuickInfoAtPosition
Mean duration (ms)	382.2	382.5	+0.1%
Mean CV	8.6%	8.6%	+0.3%
Worst duration (ms)	466.9	479.7	+2.8%
Worst identifier	Queue	JobId

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

d3-dsv/v*

Comparison details for d3-dsv/* 📊

	master	#48330	diff
Batch compilation
Memory usage (MiB)	43.6	43.7	+0.3%
Type count	2953	2959	0%
Assignability cache size	243	244	0%
Language service
Samples taken	591	654	+11%
Identifiers in tests	591	654	+11%
getCompletionsAtPosition
Mean duration (ms)	86.6	82.8	-4.4%
Mean CV	12.5%	13.0%
Worst duration (ms)	134.1	135.4	+0.9%
Worst identifier	pipedTestStringWithHeader	pipedTestStringWithHeader
getQuickInfoAtPosition
Mean duration (ms)	82.3	86.4	+5.0%
Mean CV	13.2%	11.4%	-13.6%
Worst duration (ms)	146.2	123.3	-15.6%
Worst identifier	parse	tsvParse

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@Methuselah96 Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@tomwanzek, @gustavderdrache, @borisyankov, @denisname: you can do this too.)

[Methuselah96]

Ready to merge

[typescript-bot]

I just published @types/d3-dsv@1.2.0 to npm.