Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added definitions for v1.3.5 of the socket.io lib #4894
I've moved the old definitions to legacy/socket.io-1.2.0 etc. The tests are the same, as the actual implementation hasn't changed.
When running the tests for the server lib, I get the following errors:
Which I guess is linked to Issue #4249? In any case, the errors with the node definitions, not the socket.io ones.
Hm, the two errors in Travis are:
but the line in question is:
51 and 70 are just after the "t" in "string" - am I missing something?
Finally :) Sorry about that; I'm a bit new to pull requests and travis.
On the contributions page it says: "If you need many attempts to fix errors then please flatten the history and clean the commit message." - need me to do this? Also, how do I do it?