redux-saga-routines: enhanced promisifyRoutine typing

[alexey-pelykh]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

[typescript-bot]

@alexey-pelykh Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• redux-saga-routines on npm, on unpkg (author is owner)

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 19 days — it is still unreviewed!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50321,
  "author": "alexey-pelykh",
  "headCommitOid": "f90ed8457a3f796360f12117a0e2b7febc5b508d",
  "lastPushDate": "2020-12-29T18:31:43.000Z",
  "lastActivityDate": "2020-12-29T18:31:43.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "redux-saga-routines",
      "kind": "edit",
      "files": [
        {
          "path": "types/redux-saga-routines/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/redux-saga-routines/redux-saga-routines-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alexey-pelykh"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @alexey-pelykh — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

[typescript-bot]

@alexey-pelykh The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#50321	diff
Batch compilation
Memory usage (MiB)	87.7	90.5	+3.2%
Type count	20101	20184	0%
Assignability cache size	2927	3027	+3%
Language service
Samples taken	87	115	+32%
Identifiers in tests	87	115	+32%
getCompletionsAtPosition
Mean duration (ms)	290.1	287.0	-1.1%
Mean CV	11.4%	10.6%
Worst duration (ms)	365.1	360.4	-1.3%
Worst identifier	routine_strarg	fulfill
getQuickInfoAtPosition
Mean duration (ms)	300.5	299.4	-0.4%
Mean CV	11.2%	9.9%
Worst duration (ms)	365.8	380.2	+3.9%
Worst identifier	fulfill	fulfill

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@alexey-pelykh The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@alexey-pelykh The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@alexey-pelykh The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@alexey-pelykh The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[peterblazejewicz]

Should you increase version to 3.2?
thx!

[typescript-bot]

Re-ping «anyone?»:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @alexey-pelykh.

(Ping «anyone?».)

[typescript-bot]

I just published @types/redux-saga-routines@3.1.1 to npm.