[html-pdf] localUrlAccess #53683
[html-pdf] localUrlAccess #53683
Conversation
[x] Use a meaningful title for the pull request. Include the name of the package modified. [x] Test the change in your own code. (Compile and run.) [x] Add or edit tests to reflect the change. [x] Follow the advice from the readme. [x] Avoid common mistakes. [x] Run npm test <package to test>. If changing an existing definition: [x] Provide a URL to documentation or source code which provides context for the suggested changes: adds typing for this feature [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. @westy92
|
@JuanM04 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 31 days — it is considered abandoned, and therefore closed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53683,
"author": "JuanM04",
"headCommitOid": "12d8ff18fe67794249e6c462eeec26d3b2545575",
"lastPushDate": "2021-06-08T12:37:42.000Z",
"lastActivityDate": "2021-06-08T12:38:02.000Z",
"hasMergeConflict": true,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "html-pdf",
"kind": "edit",
"files": [
{
"path": "types/html-pdf/index.d.ts",
"kind": "definition"
}
],
"owners": [
"westy92"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 856729354,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/12d8ff18fe67794249e6c462eeec26d3b2545575/checks?check_suite_id=2940840833"
} |
|
Hey @JuanM04, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
|
🔔 @westy92 — please review this PR in the next few days. Be sure to explicitly select |
|
@JuanM04 The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@JuanM04 I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Jul 8th (in a week) if the issues aren't addressed. |
typescript-bot
added
the
Abandoned
|
@JuanM04 Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
typescript-bot
added
the
Has Merge Conflict
|
@JuanM04 To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you! |
[x] Use a meaningful title for the pull request. Include the name of the package modified.
[x] Test the change in your own code. (Compile and run.)
[x] Add or edit tests to reflect the change.
[x] Follow the advice from the readme.
[x] Avoid common mistakes.
[x] Run npm test .
If changing an existing definition:
[x] Provide a URL to documentation or source code which provides context for the suggested changes: adds typing for this feature
[x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
@westy92