Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carbon-components-react Change titleText in Dropdown to be optional #57111

Merged
merged 2 commits into from
Nov 15, 2021
Merged

carbon-components-react Change titleText in Dropdown to be optional #57111

merged 2 commits into from
Nov 15, 2021

Conversation

samrobbins85
Copy link
Contributor

@samrobbins85 samrobbins85 commented Nov 11, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Add or edit tests isn't checked because from what I can see from the Carbon test the optional props are still provided, and so I don't think any change to the tests is needed

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 11, 2021

@samrobbins85 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 57111,
  "author": "samrobbins85",
  "headCommitOid": "b0f3eb1191ecec59137a6cd116a127dd4ac9a0cd",
  "lastPushDate": "2021-11-11T20:13:32.000Z",
  "lastActivityDate": "2021-11-11T20:52:15.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "carbon-components-react",
      "kind": "edit",
      "files": [
        {
          "path": "types/carbon-components-react/lib/components/Dropdown/Dropdown.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "kalbert312",
        "sgregoire",
        "matchilling"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kalbert312",
      "date": "2021-11-11T20:52:15.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 966272347,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Nov 11, 2021
@typescript-bot typescript-bot added this to Waiting for Code Reviews in Old Pull Request Status Board Nov 11, 2021
@typescript-bot
Copy link
Contributor

🔔 @kalbert312 @sgregoire @matchilling — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Old Pull Request Status Board Nov 11, 2021
….d.ts

Co-authored-by: Kyle Albert <5498623+kalbert312@users.noreply.github.com>
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Old Pull Request Status Board Nov 11, 2021
@typescript-bot
Copy link
Contributor

@kalbert312 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Old Pull Request Status Board Nov 11, 2021
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Nov 11, 2021
@weswigham weswigham merged commit 100b5d1 into DefinitelyTyped:master Nov 15, 2021
@typescript-bot typescript-bot removed this from Needs Maintainer Review in Old Pull Request Status Board Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants