carbon-components-react Change titleText in Dropdown to be optional#57111
carbon-components-react Change titleText in Dropdown to be optional#57111weswigham merged 2 commits intoDefinitelyTyped:masterfrom samrobbins85:master
carbon-components-react Change titleText in Dropdown to be optional#57111Conversation
|
@samrobbins85 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsThis PR can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57111,
"author": "samrobbins85",
"headCommitOid": "b0f3eb1191ecec59137a6cd116a127dd4ac9a0cd",
"lastPushDate": "2021-11-11T20:13:32.000Z",
"lastActivityDate": "2021-11-11T20:52:15.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "carbon-components-react",
"kind": "edit",
"files": [
{
"path": "types/carbon-components-react/lib/components/Dropdown/Dropdown.d.ts",
"kind": "definition"
}
],
"owners": [
"kalbert312",
"sgregoire",
"matchilling"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "kalbert312",
"date": "2021-11-11T20:52:15.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 966272347,
"ciResult": "pass"
} |
|
🔔 @kalbert312 @sgregoire @matchilling — please review this PR in the next few days. Be sure to explicitly select |
types/carbon-components-react/lib/components/Dropdown/Dropdown.d.ts
Outdated
Show resolved
Hide resolved
….d.ts Co-authored-by: Kyle Albert <5498623+kalbert312@users.noreply.github.com>
|
@kalbert312 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
Add or edit tests isn't checked because from what I can see from the Carbon test the optional props are still provided, and so I don't think any change to the tests is needed