Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react]: Add PropsWithChildren type for function component. #60428

Closed
wants to merge 1 commit into from

Conversation

chioio
Copy link

@chioio chioio commented May 19, 2022

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented May 19, 2022

@chioio Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 60428,
  "author": "chioio",
  "headCommitOid": "e7cb0be692c5e2354a8962027a4d8a8b6c5da62f",
  "mergeBaseOid": "8ddbf19efe34c53726e06fac519da853b8360af8",
  "lastPushDate": "2022-05-19T10:06:14.000Z",
  "lastActivityDate": "2022-05-19T16:35:55.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "eps1lon",
      "date": "2022-05-19T16:35:55.000Z"
    }
  ],
  "mainBotCommentID": 1131507214,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/e7cb0be692c5e2354a8962027a4d8a8b6c5da62f/checks?check_suite_id=6573270210"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 19, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 19, 2022
@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label May 19, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board May 19, 2022
@typescript-bot
Copy link
Contributor

@chioio The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@chioio chioio closed this May 19, 2022
@chioio chioio reopened this May 19, 2022
@@ -517,7 +517,7 @@ declare namespace React {
type FC<P = {}> = FunctionComponent<P>;

interface FunctionComponent<P = {}> {
(props: P, context?: any): ReactElement<any, any> | null;
(props: PropsWithChildren<P>, context?: any): ReactElement<any, any> | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior without PropWithChildren is intended. Check #56210 for more information.

@typescript-bot
Copy link
Contributor

@chioio One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 19, 2022
@chioio chioio closed this May 20, 2022
@chioio chioio deleted the react-18 branch May 20, 2022 07:48
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Revision needed This PR needs code changes before it can be merged. The CI failed When GH Actions fails Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants