New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meteor reference in meteor-astronomy tests #61417
Conversation
It needs to be a triple-slash reference since meteor-astronomy is a global file, not a module.
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 61417,
"author": "sandersn",
"headCommitOid": "b77eba93a907ad32a283aeaa44fb38c156a68ae4",
"mergeBaseOid": "87c7553d7c0afac0ab30c278bad67612dc80d021",
"lastPushDate": "2022-07-22T22:41:39.000Z",
"lastActivityDate": "2022-07-22T22:41:39.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "meteor-astronomy",
"kind": "edit",
"files": [
{
"path": "types/meteor-astronomy/meteor-astronomy-tests.ts",
"kind": "test"
}
],
"owners": [
"Deadly0"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1192807754,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b77eba93a907ad32a283aeaa44fb38c156a68ae4/checks?check_suite_id=7485336976"
} |
|
🔔 @Deadly0 — please review this PR in the next few days. Be sure to explicitly select |
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react (unpkg)was missing the following properties:
|
|
Touching react and meteor fixes the CI failure, so I'm going to revert those. No reason to publish them because of a bug in DT's dependency analyser. |
This reverts commit b3ea327.
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
It needs to be a triple-slash reference since meteor-astronomy is a global file, not a module. I believe that meteor also provides global mongo types, which is why two of the 3 imports go away.