Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meteor reference in meteor-astronomy tests #61417

Merged
merged 3 commits into from Jul 22, 2022

Conversation

sandersn
Copy link
Contributor

It needs to be a triple-slash reference since meteor-astronomy is a global file, not a module. I believe that meteor also provides global mongo types, which is why two of the 3 imports go away.

It needs to be a triple-slash reference since meteor-astronomy is a
global file, not a module.
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2022

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 61417,
  "author": "sandersn",
  "headCommitOid": "b77eba93a907ad32a283aeaa44fb38c156a68ae4",
  "mergeBaseOid": "87c7553d7c0afac0ab30c278bad67612dc80d021",
  "lastPushDate": "2022-07-22T22:41:39.000Z",
  "lastActivityDate": "2022-07-22T22:41:39.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "meteor-astronomy",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor-astronomy/meteor-astronomy-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Deadly0"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 1192807754,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/b77eba93a907ad32a283aeaa44fb38c156a68ae4/checks?check_suite_id=7485336976"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jul 22, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 22, 2022

🔔 @Deadly0 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 22, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jul 22, 2022
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jul 22, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react (unpkg)

was missing the following properties:

  1. unstable_act

Generated by 🚫 dangerJS against b3ea327

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jul 22, 2022
@sandersn
Copy link
Contributor Author

Touching react and meteor fixes the CI failure, so I'm going to revert those. No reason to publish them because of a bug in DT's dependency analyser.

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jul 22, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 22, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jul 22, 2022
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@sandersn sandersn merged commit beac1b9 into master Jul 22, 2022
@sandersn sandersn deleted the fix-meteor-astronomy-tests branch July 22, 2022 22:48
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The CI failed When GH Actions fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants