Fix types for dash for node-media-server

[princefishthrower]

For node-media-server

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/illuspas/Node-Media-Server
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@princefishthrower Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• node-media-server — on npm, on unpkg
  • owner-approval: @Tseberechts
  • 1 added owner: ✎@princefishthrower

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 62491,
  "author": "princefishthrower",
  "headCommitOid": "6706202474bca0014bcb2a455aea26293133e00b",
  "mergeBaseOid": "727bae0d5bc67bf017ff9746bb12c2a6a6eb8afa",
  "lastPushDate": "2022-10-02T21:11:27.000Z",
  "lastActivityDate": "2022-10-14T06:42:04.000Z",
  "mergeOfferDate": "2022-10-14T06:41:56.000Z",
  "mergeRequestDate": "2022-10-14T06:42:04.000Z",
  "mergeRequestUser": "Tseberechts",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "node-media-server",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-media-server/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node-media-server/node-media-server-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Tseberechts"
      ],
      "addedOwners": [
        "princefishthrower"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Tseberechts",
      "date": "2022-10-14T06:41:07.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1264043999,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Tseberechts — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[princefishthrower]

This pull request should resolve the issue raised in #62485 However, I'm not an expert with the node-media-server library and therefore I'm not sure that dash should be boolean. (Though if it should strictly be set to true then it is likely this "parameter" should be refactored to a const or similar within the library) Input / validation from @Tseberechts , the original creator of the typings, would be helpful!

EDIT: I dug into the source a little bit, it seems it's used at least to check if it is true: https://github.com/illuspas/Node-Media-Server/blob/97ca3c8f28f9c8579b509559ffb548d545c400a7/src/node_trans_session.js#L59 I think it anyway overall makes more sense / is a more normal pattern for this small fix to type it as boolean

[typescript-bot]

Re-ping @Tseberechts:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[typescript-bot]

@princefishthrower: Everything looks good here. I am ready to merge this PR (at 6706202) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Tseberechts: you can do this too.)

[Tseberechts]

Ready to merge