New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for issue #60426 in video.js #62538
fix for issue #60426 in video.js #62538
Conversation
|
@princefishthrower Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
@princefishthrower: I see that you have added yourself as an owner, are you sure you want to become an owner? Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 62538,
"author": "princefishthrower",
"headCommitOid": "bba840903837ae3af50cf0b65f80a5f583d806d8",
"mergeBaseOid": "23ac748f339f0c47ee82557de735e69b35cddb94",
"lastPushDate": "2022-10-03T20:30:14.000Z",
"lastActivityDate": "2022-10-11T20:34:29.000Z",
"mergeOfferDate": "2022-10-11T20:26:55.000Z",
"mergeRequestDate": "2022-10-11T20:34:29.000Z",
"mergeRequestUser": "princefishthrower",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "video.js",
"kind": "edit",
"files": [
{
"path": "types/video.js/index.d.ts",
"kind": "definition"
},
{
"path": "types/video.js/video.js-tests.ts",
"kind": "test"
}
],
"owners": [
"vbortone",
"scleriot",
"SWBennett06",
"IgelCampus",
"giofreitas",
"gjanblaszczyk",
"meikidd",
"joeflateau",
"ckybonist",
"peterblazejewicz"
],
"addedOwners": [
"princefishthrower"
],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2022-10-11T20:26:12.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1265999757,
"ciResult": "pass"
} |
|
🔔 @vbortone @scleriot @SWBennett06 @IgelCampus @giofreitas @gjanblaszczyk @meikidd @joeflateau @ckybonist @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. video.js (unpkg)was missing the following properties:
The most common way to resolve this error is to use 'export =' syntax.
as well as these 52 other properties...removeHook, VERSION, options, getPlayers, getPlayer, getAllPlayers, players, getComponent, registerComponent, getTech, registerTech, use, middleware, browser, TOUCH_ENABLED, extend, mergeOptions, bind, registerPlugin, deregisterPlugin, plugin, getPlugins, getPlugin, getPluginVersion, addLanguage, log, createLogger, createTimeRange, createTimeRanges, formatTime, setFormatTime, resetFormatTime, parseUrl, isCrossOrigin, EventTarget, on, one, off, trigger, xhr, TextTrack, AudioTrack, VideoTrack, computedStyle, dom, url, mediaSources, MediaSource, URL, HlsHandler, HlsSourceHandler, Hls |
|
Any update from anyone here? This would be my last pull request for Hacktoberfest! 🎃 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@princefishthrower thanks!
|
@princefishthrower: Everything looks good here. I am ready to merge this PR (at bba8409) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@vbortone, @scleriot, @SWBennett06, @IgelCampus, @giofreitas, @gjanblaszczyk, @meikidd, @joeflateau, @ckybonist, @peterblazejewicz: you can do this too.) |
|
Ready to merge |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould contain{ "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
If removing a declaration:
notNeededPackages.json.