Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue #60426 in video.js #62538

Merged

Conversation

princefishthrower
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/videojs/http-streaming#vhsxhr
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 3, 2022

@princefishthrower Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

@princefishthrower: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 62538,
  "author": "princefishthrower",
  "headCommitOid": "bba840903837ae3af50cf0b65f80a5f583d806d8",
  "mergeBaseOid": "23ac748f339f0c47ee82557de735e69b35cddb94",
  "lastPushDate": "2022-10-03T20:30:14.000Z",
  "lastActivityDate": "2022-10-11T20:34:29.000Z",
  "mergeOfferDate": "2022-10-11T20:26:55.000Z",
  "mergeRequestDate": "2022-10-11T20:34:29.000Z",
  "mergeRequestUser": "princefishthrower",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "video.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/video.js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/video.js/video.js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "vbortone",
        "scleriot",
        "SWBennett06",
        "IgelCampus",
        "giofreitas",
        "gjanblaszczyk",
        "meikidd",
        "joeflateau",
        "ckybonist",
        "peterblazejewicz"
      ],
      "addedOwners": [
        "princefishthrower"
      ],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2022-10-11T20:26:12.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1265999757,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Edits Owners This PR adds or removes owners Popular package This PR affects a popular package (as counted by NPM download counts). labels Oct 3, 2022
@typescript-bot
Copy link
Contributor

🔔 @vbortone @scleriot @SWBennett06 @IgelCampus @giofreitas @gjanblaszczyk @meikidd @joeflateau @ckybonist @peterblazejewicz — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Oct 3, 2022
@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

video.js (unpkg)

was missing the following properties:

  1. The declaration doesn't match the JavaScript module 'video.js'. Reason:
    The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

  1. hooks_
  2. hooks
  3. hook
  4. hookOnce
as well as these 52 other properties...

removeHook, VERSION, options, getPlayers, getPlayer, getAllPlayers, players, getComponent, registerComponent, getTech, registerTech, use, middleware, browser, TOUCH_ENABLED, extend, mergeOptions, bind, registerPlugin, deregisterPlugin, plugin, getPlugins, getPlugin, getPluginVersion, addLanguage, log, createLogger, createTimeRange, createTimeRanges, formatTime, setFormatTime, resetFormatTime, parseUrl, isCrossOrigin, EventTarget, on, one, off, trigger, xhr, TextTrack, AudioTrack, VideoTrack, computedStyle, dom, url, mediaSources, MediaSource, URL, HlsHandler, HlsSourceHandler, Hls

Generated by 🚫 dangerJS against bba8409

@princefishthrower
Copy link
Contributor Author

Any update from anyone here? This would be my last pull request for Hacktoberfest! 🎃 :)

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@princefishthrower thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 11, 2022
@typescript-bot
Copy link
Contributor

@princefishthrower: Everything looks good here. I am ready to merge this PR (at bba8409) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@vbortone, @scleriot, @SWBennett06, @IgelCampus, @giofreitas, @gjanblaszczyk, @meikidd, @joeflateau, @ckybonist, @peterblazejewicz: you can do this too.)

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Oct 11, 2022
@princefishthrower
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Oct 11, 2022
@typescript-bot typescript-bot merged commit c2bb6b1 into DefinitelyTyped:master Oct 11, 2022
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Owners This PR adds or removes owners Maintainer Approved Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants