[daterangepicker] Fixed minYear/maxYear properties for DateRangePicker

[WiseBird]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/dangrossman/daterangepicker/blob/master/daterangepicker.js#L45
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@WiseBird Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• daterangepicker — on npm, on unpkg
  • owner-approval: @SirMartin, @nertzy

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❓ Continuous integration tests have gone missing
• ✅ Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 62557,
  "author": "WiseBird",
  "headCommitOid": "8f20d3d59670d2815d3197ffab3210414fd156ad",
  "mergeBaseOid": "41d1b9237e351312a70c1bfbb251159965ce0bac",
  "lastPushDate": "2022-10-05T15:40:24.000Z",
  "lastActivityDate": "2022-12-08T19:35:39.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "daterangepicker",
      "kind": "edit",
      "files": [
        {
          "path": "types/daterangepicker/daterangepicker-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/daterangepicker/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "SirMartin",
        "smasala",
        "nertzy"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2022-12-08T19:35:39.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "SirMartin",
      "date": "2022-10-17T07:47:23.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "nertzy",
      "date": "2022-10-06T14:24:28.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1267135246,
  "ciResult": "missing"
}

[typescript-bot]

🔔 @SirMartin @smasala @nertzy — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[nertzy]

I see that the default value for those fields is a string.

But, it also seems like they can be assigned as a number, from the following: https://github.com/dangrossman/daterangepicker/blob/8495717c4007a03fd5dee422f161811fd6140c0e/daterangepicker.js#L236-L241

Would it be better to use string | number here?

[SirMartin]

It is a year, so probably a number is the most exactly and it is supported.

[Semigradsky]

http://www.daterangepicker.com/#options

There are numbers in the documentation.

[nertzy]

Looks like the value for minYear and maxYear can be either a string or a number.

So we should use string | number here instead.

[typescript-bot]

@WiseBird One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[WiseBird]

@nertzy Done

[WiseBird]

@nertzy I am sorry, who should merge the PR?

[nertzy]

I think it would usually get automatically merged once approved. I'm not sure who to ping to have this looked at...