[@types/intersects] Update to intersects@2.7.2 - #66380
Conversation
|
@c-w Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66380,
"author": "c-w",
"headCommitOid": "83d3cfb8c9146274555bba5c7607d2a503a6c6e2",
"mergeBaseOid": "d7e13a7c7789d54cf8d601352517189e82baf502",
"lastPushDate": "2023-08-14T10:53:23.000Z",
"lastActivityDate": "2023-09-13T18:03:52.000Z",
"mergeOfferDate": "2023-09-13T16:08:27.000Z",
"mergeRequestDate": "2023-09-13T18:03:52.000Z",
"mergeRequestUser": "c-w",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "intersects",
"kind": "edit",
"files": [
{
"path": "types/intersects/OTHER_FILES.txt",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt)"
},
{
"path": "types/intersects/box-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-circleOutline.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circleOutline-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circleOutline-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circleOutline-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circleOutline-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/circleOutline.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/index.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/intersects-tests.ts",
"kind": "test"
},
{
"path": "types/intersects/line-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-circleOutline.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/lineToLine.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/lineToPolygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-circleOutline.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-box.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-circle.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-ellipse.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-line.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-point.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon-polygon.d.ts",
"kind": "definition"
},
{
"path": "types/intersects/polygon.d.ts",
"kind": "definition"
}
],
"owners": [
"voxylu"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "gabritto",
"date": "2023-09-13T16:07:39.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1677105459,
"ciResult": "pass"
} |
|
🔔 @Voxylu — please review this PR in the next few days. Be sure to explicitly select |
|
@c-w The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
Re-ping @Voxylu: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
gabritto
left a comment
There was a problem hiding this comment.
I left a question about the tslint rule exemption, but in addition to that, it seems the original library is using module.exports = function ... syntax for all of the auxiliary files, so you should use the export = syntax in the TS declaration files, instead of using export default ....
Other than that, this PR looks ok.
|
@c-w One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Made the change to the export style in 9475e98. |
|
@gabritto Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
@c-w One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
@gabritto Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Ready to merge |
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition: