Skip to content

[@types/intersects] Add optional thickness parameters #66901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[@types/intersects] Add optional thickness parameters #66901

merged 1 commit into from
Oct 4, 2023

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Oct 2, 2023

  • Use a meaningful title for the pull request. Include the name of the package modified.

  • Test the change in your own code. (Compile and run.)

  • Add or edit tests to reflect the change.

  • Follow the advice from the readme.

  • Avoid common mistakes.

  • Run npm test <package to test>.

  • Provide a URL to documentation or source code which provides context for the suggested changes: in the update to v2.7 I missed two optional parameters in one method (code).

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 2, 2023

@c-w Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 66901,
  "author": "c-w",
  "headCommitOid": "c70e2e37b62fabd7332348d16fdd2697dd6af07f",
  "mergeBaseOid": "8223f512125e77a3eecb5f007cc98442cf7489d3",
  "lastPushDate": "2023-10-02T17:43:38.000Z",
  "lastActivityDate": "2023-10-04T20:26:58.000Z",
  "mergeOfferDate": "2023-10-04T19:31:06.000Z",
  "mergeRequestDate": "2023-10-04T20:26:58.000Z",
  "mergeRequestUser": "c-w",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "intersects",
      "kind": "edit",
      "files": [
        {
          "path": "types/intersects/OTHER_FILES.txt",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-other_filestxt) and not moving towards it"
        },
        {
          "path": "types/intersects/intersects-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/intersects/line-line.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "voxylu"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-10-04T19:30:21.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1743470863,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @Voxylu — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Oct 2, 2023
@typescript-bot
Copy link
Contributor

@c-w The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Check Config Changes a module config files and removed The CI failed When GH Actions fails labels Oct 2, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 4, 2023
@typescript-bot
Copy link
Contributor

@c-w: Everything looks good here. I am ready to merge this PR (at c70e2e3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Voxylu: you can do this too.)

@c-w
Copy link
Contributor Author

c-w commented Oct 4, 2023

Ready to merge

@typescript-bot typescript-bot merged commit 1808fc5 into DefinitelyTyped:master Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants