Fix for #66946 - forge-apis - add hookExpiry to HooksOptions

[princefishthrower]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tslint.json should contain { "extends": "@definitelytyped/dtslint/dt.json" }, and no additional rules.
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://aps.autodesk.com/en/docs/webhooks/v1/reference/http/webhooks/systems-system-hooks-POST/#body-structure
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@princefishthrower Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• forge-apis — on npm, on unpkg
  • 1 added owner: ✎@princefishthrower

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 67081,
  "author": "princefishthrower",
  "headCommitOid": "53b89c569270e0eee74410551acd6dca20bd815c",
  "mergeBaseOid": "5512d90cdf92cfca25b73ab4e0b9a5c1591ec57a",
  "lastPushDate": "2023-10-17T16:21:03.000Z",
  "lastActivityDate": "2023-10-18T13:55:47.000Z",
  "mergeOfferDate": "2023-10-17T23:40:24.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "forge-apis",
      "kind": "edit",
      "files": [
        {
          "path": "types/forge-apis/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/forge-apis/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "dukedhx",
        "liskaj",
        "cyrillef"
      ],
      "addedOwners": [
        "princefishthrower"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2023-10-17T23:39:41.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1766754484,
  "ciResult": "pass"
}

[princefishthrower]

I didn't know how to add a test because actually I coudn't find any references to any of the fields in HooksOptions in the tests!

[typescript-bot]

🔔 @dukedhx @liskaj @cyrillef — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[DangerBotOSS]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

forge-apis (unpkg)

was missing the following properties:

1. ApiClient
2. BadInput
3. BaseAttributesCreatedUpdated
4. BaseAttributesCreatedUpdatedAttributes
5. BaseAttributesExtensionObject

as well as these 140 other properties...

BaseAttributesExtensionObjectWithoutSchemaLink, Bucket, BucketObjects, Buckets, BucketsItems, Conflict, CreateItem, CreateItemData, CreateItemDataRelationships, CreateItemDataRelationshipsTip, CreateItemDataRelationshipsTipData, CreateItemIncluded, CreateItemRelationships, CreateItemRelationshipsStorage, CreateItemRelationshipsStorageData, CreateRef, CreateRefData, CreateRefDataMeta, CreateStorage, CreateStorageData, CreateStorageDataAttributes, CreateStorageDataRelationships, CreateStorageDataRelationshipsTarget, CreateVersion, CreateVersionData, CreateVersionDataRelationships, CreateVersionDataRelationshipsItem, CreateVersionDataRelationshipsItemData, Diagnostics, Folder, FolderAttributes, FolderRelationships, Forbidden, Formats, FormatsFormats, Hub, HubAttributes, HubRelationships, Hubs, Item, ItemAttributes, ItemCreated, ItemRelationships, Job, JobAcceptedJobs, JobDwgOutputPayload, JobDwgOutputPayloadAdvanced, JobIfcOutputPayload, JobIfcOutputPayloadAdvanced, JobIgesOutputPayload, JobIgesOutputPayloadAdvanced, JobObjOutputPayload, JobObjOutputPayloadAdvanced, JobPayload, JobPayloadInput, JobPayloadItem, JobPayloadOutput, JobPayloadMisc, JobPayloadDestination, JobStepOutputPayload, JobStepOutputPayloadAdvanced, JobStlOutputPayload, JobStlOutputPayloadAdvanced, JobSvfOutputPayload, JobSvfOutputPayloadAdvanced, JobSvf2OutputPayload, JobSvf2OutputPayloadAdvanced, JobThumbnailOutputPayload, JobThumbnailOutputPayloadAdvanced, JsonApiAttributes, JsonApiCollection, JsonApiDocument, JsonApiDocumentBase, JsonApiError, JsonApiErrorErrors, JsonApiErrorLinks, JsonApiLink, JsonApiLinks, JsonApiLinksPaging, JsonApiLinksRelated, JsonApiLinksSelf, JsonApiMeta, JsonApiMetaLink, JsonApiRelationships, JsonApiRelationshipsLinksExternalResource, JsonApiRelationshipsLinksInternal, JsonApiRelationshipsLinksInternalResource, JsonApiRelationshipsLinksRefs, JsonApiRelationshipsLinksRefsLinks, JsonApiResource, JsonApiTypeId, JsonApiVersion, JsonApiVersionJsonapi, Manifest, ManifestChildren, ManifestDerivative, Message, Messages, Metadata, MetadataCollection, MetadataData, MetadataMetadata, MetadataObject, NotFound, ObjectDetails, ObjectFullDetails, ObjectFullDetailsDeltas, ObjectS3Download, ObjectS3Upload, ObjectCompleteS3Upload, Permission, PostBucketsPayload, PostBucketsPayloadAllow, PostBucketsSigned, PostObjectSigned, Project, ProjectAttributes, ProjectRelationships, Projects, Reason, Refs, RelRef, RelRefMeta, ResourceId, Result, Storage, StorageCreated, StorageRelationships, StorageRelationshipsTarget, StorageRelationshipsTargetData, TopFolders, UserProfile, UserProfileProfileImages, Version, VersionAttributes, VersionCreated, VersionRelationships, Versions, IssuesApi, setDebug

Generated by 🚫 dangerJS against 53b89c5

[sandersn]

Maintainer note: mergebot didn't notice that package.json contains an additional owner now

[typescript-bot]

@princefishthrower The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@princefishthrower The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[sandersn]

Ready to merge

[sandersn]

Ready to merge

[sandersn]

Hm, I guess @typescript-bot only listens to people it has pinged. I thought admins were on the list before.