Skip to content

Conversation

@acusti
Copy link
Contributor

@acusti acusti commented Sep 19, 2024

Types for new React v19 props for <link> element and <style> element

@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 19, 2024

@acusti Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 70601,
  "author": "acusti",
  "headCommitOid": "34bdbd4113a3754961ca88c0f5b2a3f9e8d8b1ed",
  "mergeBaseOid": "60074fc266ed8501f94dc7b2112c8be043aeaa7a",
  "lastPushDate": "2024-09-19T00:34:49.000Z",
  "lastActivityDate": "2024-09-19T00:34:49.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/canary.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/test/canary.tsx",
          "kind": "test"
        },
        {
          "path": "types/react/ts5.0/canary.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react/ts5.0/test/canary.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav",
        "Semigradsky",
        "mattpocock"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2359677757,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

@acusti acusti force-pushed the react/new-link-style-props branch from db1a66b to 34bdbd4 Compare September 19, 2024 15:21
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eps1lon eps1lon merged commit 7376503 into DefinitelyTyped:master Sep 19, 2024
ankur22 pushed a commit to grafana/k6-DefinitelyTyped that referenced this pull request Sep 27, 2024
alino20 pushed a commit to alino20/DefinitelyTyped that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants