replace internal module to namespace #8605

Merged
merged 1 commit into from Mar 17, 2016

Projects

None yet

10 participants

@vvakame vvakame replace internal module to namespace
14fe431
@basarat
Member
basarat commented Mar 17, 2016

Thanks!

Since you have everyone here I wanted to share a big change coming : Microsoft/TypeScript#7125 (comment) That is going to allow us to write definitions that do not pollute the global namespace unless the user explicitly adds a library reference. So we get to write a single definition for both external module and global users 🌹

@stephenlautier
Contributor

👍

@mkp05
Contributor
mkp05 commented Mar 17, 2016

👍

@abreits
Contributor
abreits commented Mar 17, 2016

👍

@AkosLukacs
Contributor

👍

@vvakame
Member
vvakame commented Mar 17, 2016

good news!

@vvakame vvakame merged commit 89f1449 into master Mar 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@vvakame vvakame deleted the replace-module2namespace branch Mar 17, 2016
@vvakame
Member
vvakame commented Mar 17, 2016

thanks all!

@horiuchi
Member

👍

@Justin-Credible
Contributor

👍

@RReverser
Contributor

People, there are now proper Github reactions, please use them instead of +1 / 👍 comments. Thanks! :)

@cyrilschumacher
Contributor

👍

@staxmanade staxmanade referenced this pull request in DefinitelyTyped/NugetAutomation Mar 23, 2016
Open

Don't allow really long git-commit messages #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment