Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Helmet's xssFilter options #8818

Merged

Conversation

@EvanHahn
Copy link
Contributor

EvanHahn commented Apr 2, 2016

case 2. Improvement to existing type definition.

Made two improvements here:

  1. xssFilter takes an object with a certain interface, not just any Object.
  2. Changed the @summary documentation.

I maintain Helmet, so let me know if there's anything else I can help with here!

Made two improvements here:

1. `xssFilter` takes an object with a certain interface, not just any
   `Object`.
2. Changed the `@summary` documentation.
@dt-bot

This comment has been minimized.

Copy link
Member

dt-bot commented Apr 2, 2016

helmet/helmet.d.ts

to author (@cyrilschumacher). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?
@EvanHahn EvanHahn mentioned this pull request Apr 2, 2016
@cyrilschumacher

This comment has been minimized.

Copy link
Contributor

cyrilschumacher commented Apr 3, 2016

👍

@vvakame vvakame merged commit 9d9bd17 into DefinitelyTyped:master Apr 5, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.