Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Helmet publicKeyPins definitions #9017

Merged

Conversation

@EvanHahn
Copy link
Contributor

EvanHahn commented Apr 16, 2016

case 2. Improvement to existing type definition.

helmet.publicKeyPins takes an object of a certain shape instead of any Object.

`helmet.publicKeyPins` takes an object of a certain shape instead of any
Object.
@dt-bot

This comment has been minimized.

Copy link
Member

dt-bot commented Apr 16, 2016

helmet/helmet.d.ts

to author (@cyrilschumacher). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?
@cyrilschumacher

This comment has been minimized.

Copy link
Contributor

cyrilschumacher commented Apr 17, 2016

👍

@vvakame vvakame merged commit db57ec3 into DefinitelyTyped:master Apr 23, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.