New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react.TypeScript.DefinitelyTyped not owned by DT #14

Open
staxmanade opened this Issue Apr 25, 2015 · 25 comments

Comments

Projects
None yet
7 participants
@staxmanade
Copy link
Member

staxmanade commented Apr 25, 2015

Hey All,

The nuget automation is currently failing up on AppVeyor with the following error:

NuGet.exe : Failed to process request. 'The specified API key is invalid or does not have permission to access the specified package.'. 
At C:\projects\nugetautomation\CreatePackages.ps1:187 char:25
    +                         & $nuget push "$packageFolder.nupkg" -ApiKey $nugetApiKe ...
    +                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Failed to proce...ied package.'. :String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

The remote server returned an error: (403) Forbidden.

This error is because @wizzard0 claimed the react.TypeScript.DefinitelyTyped name on NuGet, which is unfortunate.

If @wizzard0 is listening, could you please rename your nuget package to something else (not using DT's convention) and then either add us as an owner to the package or, deleting yours completely so our nuget process can correctly publish to react.TypeScript.DefinitelyTyped?

Thanks

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented May 3, 2015

Some other packages claiming the DefinitelyTyped naming convention (but not ones we can publish to on NuGet)

https://www.nuget.org/packages/Sjcl.TypeScript.DefinitelyTyped/ @Evgenus
https://www.nuget.org/packages/Jsbn.TypeScript.DefinitelyTyped/ @Evgenus
https://www.nuget.org/packages/BigInt.TypeScript.DefinitelyTyped/ @Evgenus
https://www.nuget.org/packages/TGrid.TypeScript.DefinitelyTyped/ @TesserisPro

@Evgenus could you please consider renaming your NuGet packages to avoid conflicting with the same DT convention we've setup {project}.TypeScript.DefinitelyTyped? You could consider using something like BigInt.TypeScript.Evgenus (so it won't conflict with the DefinitelyTyped name?)

This would really be helpful and avoid confusion in the community. It looks like you may know @wizzard0 - would you mind reaching out to him about the React package? Thanks

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented May 3, 2015

Hi @staxmanade,

Initially, the packages are named like this for they to be discoverable on NuGet. I'm considering renaming to something like react.TypeScript.DefinitelyTyped.wizzard0, but that also requires patching our internal infrastructure (the react package in question is not compatible with DT one, so we can't just replace one with another).

Can this wait a bit while we finish our other project please?

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented May 3, 2015

Great, thanks for responding... We don't really have a choice to wait :) since we don't have permissions...

But yes, please do the work you need and let me know if you need any help cleaning things up.

For now, I'm excluding these packages explicitly from trying to publish, but when this project can reclaim the id's on NuGet, let me know so we can make sure the transition works out.

Appreciate you being willing to work through this!

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Dec 28, 2015

@wizzard0 we are getting some flack for not having the DT typings properly represented in NuGet. Could you please make some traction at giving back the convention based DT NuGet name?

@NuclearFishin

This comment has been minimized.

Copy link

NuclearFishin commented Jan 5, 2016

Hi all, I have just attempted to write a prototype app using React + TypeScript and my difficulties getting started have lead me to this issue. It would appear as though the current package owned by @wizzard0 has a bug whereby after installing the React.TypeScript.DefinitelyTyped package, no d.ts files are actually added to the project. (It appears to be an issue within the <files> section of the .nuspec file.)

I would be happy to follow up this specific issue within @wizzard0's project, but I think the main priority would be to relinquish the ownership of React.TypeScript.DefinitelyTyped so that the DT folks can release their package. I thought I would mention it here just to highlight the urgency since developers currently have no ability to access TypeScript definitions for React, either through the "unofficial" package, or the DT one.

@dberryalliance

This comment has been minimized.

Copy link

dberryalliance commented Jan 16, 2016

What the DT team should do is submit a complaint to the NuGet team for violation of Intellectual Property, in that @wizzard0 is using the "DefinitelyTyped" name, but is not publishing on behalf of the DefinitelyTyped community.

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 16, 2016

I did send a complaint (not with that sort of language) but NuGet team responded it's a first-come-first-serve.

Would just be great if everyone who owns these packages could rename theirs and notify me so I can re-enable the proper DT version. https://github.com/DefinitelyTyped/NugetAutomation/blob/master/CreatePackages.ps1#L16

@johnnyreilly

This comment has been minimized.

Copy link
Member

johnnyreilly commented Jan 16, 2016

It's frustrating that there's effectively "squatter's rights" on NuGet but this is Open Source I guess.

@wizzard0 would you be able to rename your package please? It's causing problems for other people and creating confusion. It would be fantastic to resolve this.

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 16, 2016

Reaching out to all of the following who have also contributed to the other project in hopes they may know @wizzard0 - or be able to help push this forward.

Can any of you help out here? (@malbertife @jnetterf, @liammclennan, @Evgenus)

We'd really appreciate it.

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jan 20, 2016

hi guys, I restored my NuGet account and would be happy to transfer the package ownership - nuget does not allow me to relinquish a name so as not to break apps that might be using the packages, I can only add people with publishing rights. Who shall I add?

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 20, 2016

@wizzard0 that's fantastic! - NuGet has an option to "delete" a package - https://docs.nuget.org/create/deleting-packages I don't know if that will allow us to take it over going forward.

The last paragraph of that page says:

If you run into an exceptional situation where you think one of your packages must be deleted, this can be handled manually by the NuGet team. e.g. if there is a copyright infringement issue, or potentially harmful content, that could be a valid reason to delete it. You should submit a support request through NuGet Gallery in that case.

I wonder if we can reach out to NuGet to delete it for us?

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jan 21, 2016

@staxmanade i'd better just add you (or whoever mirrors DT to nuget) so my old versions would be persisted too

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 21, 2016

@wizzard0 I PM'd you my email address.

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jan 21, 2016

@staxmanade nuget requires an username, not email

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jan 21, 2016

added DefinitelyTyped and staxmanade

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 21, 2016

I don't know if there's a timing thing - but DefinitelyTyped (on NuGet) still doesn't appear to have access (yet). At least the API key used for this account isn't yet working under react.TypeScript.DefinitelyTyped.

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jan 21, 2016

you need to log in interactively to DT and approve the transfer

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 21, 2016

Thanks @wizzard0 I found that an email was sent that I have to click a link to accept. (I did that for staxmanade - but haven't seen the email yet for DefinitelyTyped - I'll keep an eye out for it.

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 22, 2016

Just an update on this thread - I have not yet seen any emails to the DefinitelyTyped email (even after I tried changing it to a different email and removing/re-adding it to the package) - I've reached out to NuGet support to see where it could be hung in the process.

@staxmanade

This comment has been minimized.

Copy link
Member Author

staxmanade commented Jan 25, 2016

No response yet from support@nuget - just pinged them again.

@dberryalliance

This comment has been minimized.

Copy link

dberryalliance commented Jun 15, 2016

Any updates?

@wizzard0

This comment has been minimized.

Copy link

wizzard0 commented Jun 16, 2016

@dberryalliance so far it's stuck somewhere around nuget support, I suppose

@lilred

This comment has been minimized.

Copy link

lilred commented Jul 20, 2016

I just wanted to chime in to mention that I really appreciate the work you're doing on this issue, and I hope it comes to a swift conclusion!

@smithkl42

This comment has been minimized.

Copy link

smithkl42 commented Jan 31, 2017

Any update on this? Is the only alternative to grab the typings directly from DefinitelyTyped?

@johnnyreilly

This comment has been minimized.

Copy link
Member

johnnyreilly commented Feb 1, 2017

I believe yes - or npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment