Refactor CI to use cargo-zigbuild and split bindings workflow#689
Open
richarddd wants to merge 6 commits into
Open
Refactor CI to use cargo-zigbuild and split bindings workflow#689richarddd wants to merge 6 commits into
richarddd wants to merge 6 commits into
Conversation
…e bindings regeneration to a dedicated workflow
…2-wasip2 bindings
…ssing zig glibc stubs
… zig ships the missing glibc stubs
…port PPC64 ELFv1 executables
Sytten
requested changes
May 17, 2026
Collaborator
Sytten
left a comment
Sytten
left a comment
There was a problem hiding this comment.
At some point it would be easier to use nix LOL
|
|
||
| - name: Set up zig | ||
| if: matrix.builder == 'zigbuild' | ||
| uses: mlugg/setup-zig@v2 |
|
|
||
| - name: Install cargo-zigbuild | ||
| if: matrix.builder == 'zigbuild' | ||
| uses: taiki-e/install-action@v2 |
|
|
||
| - name: Set up msys2 | ||
| if: matrix.builder == 'msys2' | ||
| uses: msys2/setup-msys2@v2 |
Addresses review feedback on PR DelSkayn#689: third-party actions are now pinned to the upstream tag's commit SHA rather than mutable major-version tags, preventing surprise upgrades or supply-chain attacks via tag rewrites. Pinned (latest stable as of 2026-05): - mlugg/setup-zig v2.2.1 d1434d0 - taiki-e/install-action v2.79.0 7be9fd8 - msys2/setup-msys2 v2.31.1 e989830 Applied in both bindings.yml and ci.yml where this PR added or moves the action invocations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-target apt and musl-cross toolchain installs with cargo-zigbuild, moves bindings regeneration into a dedicated workflow triggered by submodule or build-script changes, and drops the update-bindings branch trigger that caused self-triggering runs and wrong PR base branches.