Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich android play store upload #26

Closed
wants to merge 5 commits into
base: develop
from

Conversation

Projects
None yet
1 participant
@timmutton
Copy link
Collaborator

timmutton commented Mar 14, 2019

Ok, so this might look a bit scary at first, but this PR represents 2 main changes to how we are uploading to the play store.

  • Support productFlavors and custom apk names
  • Derive version name rather than pass it in as a parameter

The second one is more interesting, because its not uncommon to have more than one apk in the project. To resolve this, we're trying to filter out APKs that we know are not appropriate for release, and if theres less or more than one remaining, we tell the project own to figure it out.

The criteria by which were filtering are:

  • Its not a child of the outputs file
  • It contains contain signed/aligned/uninstrumented in the name (generally indicates its an intermediary file)
  • Its not signed
  • It is debuggable

If were OK with this logic, I'll extract it out into a util method so that hockeyapp can use them

@timmutton timmutton requested review from dotb and davetao Mar 14, 2019

@timmutton timmutton closed this Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.