Skip to content

Show convergence bottleneck nodes to users#1440

Merged
SouthEndMusic merged 14 commits intomainfrom
indicate_problematic_basins
May 8, 2024
Merged

Show convergence bottleneck nodes to users#1440
SouthEndMusic merged 14 commits intomainfrom
indicate_problematic_basins

Conversation

@SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Apr 29, 2024

Fixes #452.

To do:

@SouthEndMusic SouthEndMusic marked this pull request as draft April 29, 2024 13:43
@SouthEndMusic SouthEndMusic changed the title Add unstable test model Show convergence bottleneck nodes to users Apr 29, 2024
@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented May 6, 2024

I've implemented this now, but the result is not what I expect. The problematic basins (which get drained extremely quickly) in the test model have error $0$, and the others have some positive error. We need to think about under which circumstances, say which values of retcode this method makes sense.

Edit: I get the expected basins now.

@SouthEndMusic SouthEndMusic marked this pull request as ready for review May 7, 2024 10:39
@SouthEndMusic SouthEndMusic requested a review from evetion May 7, 2024 10:41
@Jingru923 Jingru923 self-requested a review May 7, 2024 11:21
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SouthEndMusic SouthEndMusic merged commit 943c04c into main May 8, 2024
@SouthEndMusic SouthEndMusic deleted the indicate_problematic_basins branch May 8, 2024 09:47
SouthEndMusic pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show convergence bottleneck nodes to users

3 participants