Conversation
Huite
approved these changes
Jun 25, 2024
| self.setHeaderLabels([""]) | ||
| self.setHeaderHidden(False) | ||
| self.setColumnCount(1) | ||
| header = self.header() |
Contributor
There was a problem hiding this comment.
Do we still need any header logic? There's only a single column, so there's no sections to speak of. The resizing behavior only matters for multiple columns too.
| @@ -50,10 +50,10 @@ def __init__(self, parent: QWidget | None): | |||
| self.setSizePolicy(QSizePolicy.Minimum, QSizePolicy.Preferred) | |||
| self.setHeaderLabels([""]) | |||
Contributor
There was a problem hiding this comment.
Does it make sense to write " Layer" here as a label here? (Note the spaces in front, otherwise it looks too cramped...)
Contributor
|
It makes sense that this fixes it (although still weird that doesn't just raises an exception). I've approved, although take a look at my review comments -- since you're looking at this anyway. |
Member
Author
|
Thanks, addressed comments in 7cd92b3. Looks good now:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #993, by creating the column count first before setting their properties, and changing the index to 0 (0-based, first), since we now have only one column.
Based on the suggestion by @Huite in #993 (comment).
By repeatedly running
pixi run test-ribasim-qgis-uiI am quite confident this fixes the issue. If I change the 0 back to 1 I got a crash again within a few tries.