Allocate to UserDemand from directly connected basin if possible#1581
Merged
Conversation
visr
reviewed
Jul 2, 2024
Member
Link to discussion: #1428 (comment) We should directly test this since it will have a large impact on results. Would a This behavior probably also needs to be in the user docs, probably https://deltares.github.io/Ribasim/reference/node/user-demand.html, maybe https://deltares.github.io/Ribasim/concept/allocation.html. |
visr
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1545
Some notes on this PR:
Basinupstream of aUserDemandhas a level demand to define the source capacity of the basinBasinto theUserDemandalso shows up inallocation_flow.arrow, which requires some refactoring. That is fine though, as that refactor is needed anyway for Optimize allocation per source in a fixed order #565, where we probably want to aggregate the allocation flows for output over the optimizations for all sources in stead of saving them per source