Add ContinuousControl node#1602
Merged
Merged
Conversation
SouthEndMusic
marked this pull request as draft
July 2, 2024 12:37
SouthEndMusic
changed the title
ContinuousControl node
2 tasks
…_flow_rate also in formulate_flow!
SouthEndMusic
marked this pull request as ready for review
July 17, 2024 16:20
Collaborator
Author
|
For those wondering why the diff is so big: this is a large PR, but the majority now actually comes from changes to pixi.lock. I don't know what is happening there, the file keeps being updated automatically. I saw I am behind on my pixi version, so I now upgraded to 0.25.0. |
visr
reviewed
Jul 22, 2024
visr
left a comment
visr
left a comment
Member
There was a problem hiding this comment.
Left some comments.
As discussed, let's remove min_output and max_output as well. I also noticed we need to update SPATIALCONTROLNODETYPES in ribasim_qgis.
visr
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #720.