Validate level with upstream basin#1607
Merged
Merged
Conversation
visr
reviewed
Jul 4, 2024
visr
reviewed
Jul 9, 2024
visr
left a comment
visr
left a comment
Member
There was a problem hiding this comment.
Looks quite close, I have left some comments.
Contributor
Author
|
In the validation of tabulated rating curve level, currently many models that has tabulated rating curve with upstream basin fails. The reason is that in the Ribasim python, the level is [0.0 1.0], but during initialization, we add 1.0 to avoid negative extrapolation for Q (line 121) Once an idea of during validation before the parameter initialization came up, but it is found to be impossible because the validation request the graph information. For now, I add the 1.0 back during the validation
But this make us question the robustness of the extrapolation Huite opened an issue to research this robustness problem #1621 |
visr
approved these changes
Jul 16, 2024
SouthEndMusic
pushed a commit
that referenced
this pull request
Sep 9, 2024
This is like #1607, but now running the same validation for Pump instead of only Outlet, because Pump now also supports `min_upstream_level`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1591
An error will be given when the
levelin tabulated rating curve is lower than upstream bottom.An error will be given when the
min_crest_levelin outlet is lower than upstream bottom. In the validation function, it will set themin_crest_levelto the basin bottom if this parameter was not specified.