Skip to content

Conversation

@visr
Copy link
Member

@visr visr commented Jul 15, 2024

This does not remove the Terminal type from the core, as it causes more issues than it's worth, as suggested in #1209.

Fixes #1209

@visr visr requested a review from Jingru923 July 15, 2024 21:05
@visr visr force-pushed the terminal-static branch from 1ef15e1 to 70fcaa2 Compare July 15, 2024 21:30
Copy link
Contributor

@Jingru923 Jingru923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@Jingru923 Jingru923 merged commit b0784ce into main Jul 16, 2024
@Jingru923 Jingru923 deleted the terminal-static branch July 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Terminal / static as it is not needed

3 participants