level_demand can now be without max_level or min_level#1629
Merged
Conversation
Jingru923
changed the title
level_demand can now be without max_level or min
Jingru923
changed the title
level_demand can now be without max_level or minlevel_demand can now be without max_level or min_level
Collaborator
SouthEndMusic
left a comment
SouthEndMusic
left a comment
There was a problem hiding this comment.
It's nice that we have this now, but you should also add a test where you run a model with the default min_level and max_level and check that there us no crash.
SouthEndMusic
approved these changes
Jul 22, 2024
Collaborator
SouthEndMusic
left a comment
SouthEndMusic
left a comment
There was a problem hiding this comment.
Looks good, I have one single suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1589