Merged
Conversation
SouthEndMusic
changed the title
Jingru923
suggested changes
Aug 15, 2024
Jingru923
approved these changes
Aug 19, 2024
Contributor
Jingru923
left a comment
Jingru923
left a comment
There was a problem hiding this comment.
The new 2D basin visualization looks great!
docs/reference/node/basin.qmd
Outdated
| The level to storage relationship gives the volume of water in the basin at a given level, which is given by the integral over the level to area relationship from the basin bottom to the given level: | ||
|
|
||
| $$ | ||
| S(l) = \int_{l_0}^l A(l')\text{d}l'. |
Contributor
There was a problem hiding this comment.
In the paragraph right before 1.4.1 interpolation, the level is defined as
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1152