Conversation
Jingru923
suggested changes
Aug 22, 2024
Contributor
Jingru923
left a comment
Jingru923
left a comment
There was a problem hiding this comment.
Looks good! Can you have a look at these comments?
Member
Author
|
Thanks. I forgot that it was curly braces, not square braces, to label sections: |
Jingru923
approved these changes
Aug 22, 2024
Contributor
Jingru923
left a comment
Jingru923
left a comment
There was a problem hiding this comment.
Can you change the hyperlink of "Collect demand" and "Allocate"?
Other things are good!
Comment on lines
+34
to
+35
| - ["Collect demand"](#sec-allocation-overview). This step initialize and solve the optimization problems that collects the demand from the subnetworks. | ||
| - ["Allocate"](#sec-allocation-overview). This step solves the optimization problems that allocates the demand. For the main network this step allocates to the subnetworks and demand nodes that are in the main network. For the subnetwork this step allocates to the demand nodes. |
Contributor
There was a problem hiding this comment.
These two link are supposed to link to this page:
https://ribasim.org/concept/allocation.html#the-high-level-algorithm
Member
Author
There was a problem hiding this comment.
Done, didn't realize this was on a different allocation.qmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://ribasim.org/
https://ribasim.nl/