Use relaxed square root for ManningResistance#1750
Merged
SouthEndMusic merged 4 commits intomainfrom Aug 22, 2024
Merged
Conversation
Contributor
|
Looks good, and it's immediately clear that only at It's probably a lot cheaper to compute than a transcendental function as well! |
Huite
approved these changes
Aug 22, 2024
visr
approved these changes
Aug 22, 2024
Merged
verheem
added a commit
that referenced
this pull request
Jun 12, 2025
Fixes #2356 by reverting to a previous implementation first introduced at #1750 Achieved performance gain: HollandseDelta_parameterized_2025_6_0 relaxed_root_old = Computation time: 1 minute, 17 seconds, 392 milliseconds relaxed_root = Computation time: 3 minutes, 9 seconds, 247 milliseconds --------- Co-authored-by: Martijn Visser <mgvisser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1743.