Re-enable BackTracking
#1761
Merged
Re-enable BackTracking
#1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Since the sensible gradients don't fix the Crystal model with BackTracking, I guess we should not enable that yet? How do these gradients compare with Shampine's advice in #1705 (comment), should we bring that back as well in this PR? |
Collaborator
Author
|
I added Shampine's advice, but it doesn't seem to change anything |
visr
reviewed
Aug 29, 2024
| get_du, | ||
| AbstractNLSolver, | ||
| relax!, | ||
| _compute_rhs!, |
Member
There was a problem hiding this comment.
I guess we may be able to stop using this internal function when we upstream this?
SouthEndMusic
changed the title
BackTracking
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackTrackingas relaxation is now enabled again, with a thin wrapper to reject it when the residual gets worse. Upstream issue:SciML/OrdinaryDiffEq.jl#2442